Re: [PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-27 Thread David Sterba
Hi, please don't forget to mention what changed in a revised version On Sat, May 25, 2013 at 03:16:39PM +0100, Filipe David Borba Manana wrote: @@ -228,6 +227,8 @@ out: free(chunk_root); free(dev_root); free(csum_root); + if (fs_info) +

Re: [PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-27 Thread Filipe David Manana
On Mon, May 27, 2013 at 1:12 PM, David Sterba dste...@suse.cz wrote: Hi, please don't forget to mention what changed in a revised version Yeah, sorry, it was my first usage of git send-email (as described in the wiki). On Sat, May 25, 2013 at 03:16:39PM +0100, Filipe David Borba Manana

Re: [PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-27 Thread David Sterba
On Mon, May 27, 2013 at 01:31:13PM +0100, Filipe David Manana wrote: Right. Just thought it was better to check if the calloc() for fs_info succeeded before derreferencing it for free'ing its super_copy member (the function's code doesn't check if any of the malloc() / calloc() calls returned

[PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-25 Thread Filipe David Borba Manana
There was a missing free() call against fs_info-super_copy in several places: 1) close_ctree() 2) open_ctree_broken() on failure 3) __open_ctree_fd() on failure Filipe David Borba Manana (1): Btrfs-progs: Add missing free() against fs_info-super_copy btrfs-find-root.c |4 ++--

[PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-25 Thread Filipe David Borba Manana
There was a missing free() call against fs_info-super_copy in several places: 1) close_ctree() 2) open_ctree_broken() on failure 3) __open_ctree_fd() on failure Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- btrfs-find-root.c |4 ++-- disk-io.c |5 +++-- 2

[PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-25 Thread Filipe David Borba Manana
There was a missing free() call against fs_info-super_copy in several places: 1) close_ctree() 2) open_ctree_broken() on failure 3) __open_ctree_fd() on failure Filipe David Borba Manana (1): Btrfs-progs: Add missing free() against fs_info-super_copy btrfs-find-root.c |5 +++--

[PATCH] Btrfs-progs: Add missing free() against fs_info-super_copy

2013-05-25 Thread Filipe David Borba Manana
There was a missing free() call against fs_info-super_copy in several places: 1) close_ctree() 2) open_ctree_broken() on failure 3) __open_ctree_fd() on failure Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- btrfs-find-root.c |5 +++-- disk-io.c |6 -- 2