Re: [PATCH] Improve balance performance when qgroups are turned on

2016-05-31 Thread Mark Fasheh
On Wed, Jun 01, 2016 at 09:31:14AM +0800, Qu Wenruo wrote: > Thanks for the test case. > It would be better if you could submit a test case for it. Yeah I'll handle this. > Reproduced the problem. I'll track it down. > Seems to be related with metadata. Thanks, please CC me on any patches.

Re: [PATCH] Improve balance performance when qgroups are turned on

2016-05-31 Thread Qu Wenruo
At 06/01/2016 08:50 AM, Mark Fasheh wrote: On Mon, May 30, 2016 at 03:48:14PM +0800, Qu Wenruo wrote: Mark Fasheh wrote on 2016/05/26 17:18 -0700: The btrfs balance operation is significantly slower when qgroups are enabled. To the best of my knowledge, a balance shouldn't have an effect

Re: [PATCH] Improve balance performance when qgroups are turned on

2016-05-31 Thread Mark Fasheh
On Mon, May 30, 2016 at 03:48:14PM +0800, Qu Wenruo wrote: > > > Mark Fasheh wrote on 2016/05/26 17:18 -0700: > >The btrfs balance operation is significantly slower when qgroups are > >enabled. To the best of my knowledge, a balance shouldn't have an effect on > >qgroups counts (extents are not

Re: [PATCH] Improve balance performance when qgroups are turned on

2016-05-30 Thread Qu Wenruo
Mark Fasheh wrote on 2016/05/26 17:18 -0700: The btrfs balance operation is significantly slower when qgroups are enabled. To the best of my knowledge, a balance shouldn't have an effect on qgroups counts (extents are not changing between subvolumes), so we don't need to actually run the

[PATCH] Improve balance performance when qgroups are turned on

2016-05-26 Thread Mark Fasheh
The btrfs balance operation is significantly slower when qgroups are enabled. To the best of my knowledge, a balance shouldn't have an effect on qgroups counts (extents are not changing between subvolumes), so we don't need to actually run the qgroup code when we balance. Since there's only one