On Tue, Jun 24, 2014 at 08:12:30AM +0900, Satoru Takeuchi wrote:
(2014/06/23 22:44), David Sterba wrote:
On Wed, Jun 18, 2014 at 03:01:32PM +0900, Satoru Takeuchi wrote:
(2014/06/13 7:57), Adam Buchbinder wrote:
It's 32 bits as defined in ctree.h, but the struct had it as 64 bits.
Found
On Wed, Jun 18, 2014 at 03:01:32PM +0900, Satoru Takeuchi wrote:
(2014/06/13 7:57), Adam Buchbinder wrote:
It's 32 bits as defined in ctree.h, but the struct had it as 64 bits.
Found using MemorySanitizer.
Signed-off-by: Adam Buchbinder abuchbin...@google.com
It looks good to me.
(2014/06/23 22:44), David Sterba wrote:
On Wed, Jun 18, 2014 at 03:01:32PM +0900, Satoru Takeuchi wrote:
(2014/06/13 7:57), Adam Buchbinder wrote:
It's 32 bits as defined in ctree.h, but the struct had it as 64 bits.
Found using MemorySanitizer.
Signed-off-by: Adam Buchbinder
Hi Adam,
(2014/06/13 7:57), Adam Buchbinder wrote:
It's 32 bits as defined in ctree.h, but the struct had it as 64 bits.
Found using MemorySanitizer.
Signed-off-by: Adam Buchbinder abuchbin...@google.com
It looks good to me.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
I'd like to follow up on this a bit, because the way I found it was *weird*.
MSan found an uninitialized write. Reproducing the issue through GDB
showed that there's a struct mdrestore_struct type with a member of
type u64 called 'leafsize' which was... half-initialized? Four bytes
were
