Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-05-01 Thread David Sterba
On Sun, Apr 29, 2018 at 08:33:49AM +0800, Qu Wenruo wrote: > > > On 2018年04月29日 01:45, David Sterba wrote: > > On Sat, Apr 28, 2018 at 06:42:06PM +0200, David Sterba wrote: > >> On Thu, Apr 26, 2018 at 02:24:25PM +0800, Qu Wenruo wrote: > >>> fs_info can be extracted from

Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-04-28 Thread Qu Wenruo
On 2018年04月29日 01:45, David Sterba wrote: > On Sat, Apr 28, 2018 at 06:42:06PM +0200, David Sterba wrote: >> On Thu, Apr 26, 2018 at 02:24:25PM +0800, Qu Wenruo wrote: >>> fs_info can be extracted from btrfs_block_group_cache, and all >>> btrfs_block_group_cache is created by

Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-04-28 Thread David Sterba
On Sat, Apr 28, 2018 at 06:42:06PM +0200, David Sterba wrote: > On Thu, Apr 26, 2018 at 02:24:25PM +0800, Qu Wenruo wrote: > > fs_info can be extracted from btrfs_block_group_cache, and all > > btrfs_block_group_cache is created by btrfs_create_block_group_cache() > > with fs_info initialized, no

Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-04-28 Thread David Sterba
On Thu, Apr 26, 2018 at 02:24:25PM +0800, Qu Wenruo wrote: > fs_info can be extracted from btrfs_block_group_cache, and all > btrfs_block_group_cache is created by btrfs_create_block_group_cache() > with fs_info initialized, no need to worry about NULL pointer > dereference. Famous last words. [

Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-04-26 Thread David Sterba
On Thu, Apr 26, 2018 at 09:27:11AM +0300, Nikolay Borisov wrote: > > > On 26.04.2018 09:24, Qu Wenruo wrote: > > fs_info can be extracted from btrfs_block_group_cache, and all > > btrfs_block_group_cache is created by btrfs_create_block_group_cache() > > with fs_info initialized, no need to

Re: [PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-04-26 Thread Nikolay Borisov
On 26.04.2018 09:24, Qu Wenruo wrote: > fs_info can be extracted from btrfs_block_group_cache, and all > btrfs_block_group_cache is created by btrfs_create_block_group_cache() > with fs_info initialized, no need to worry about NULL pointer > dereference. > > Signed-off-by: Qu Wenruo

[PATCH] btrfs: trace: Remove unnecessary fs_info parameter for btrfs__reserve_extent event class

2018-04-26 Thread Qu Wenruo
fs_info can be extracted from btrfs_block_group_cache, and all btrfs_block_group_cache is created by btrfs_create_block_group_cache() with fs_info initialized, no need to worry about NULL pointer dereference. Signed-off-by: Qu Wenruo --- fs/btrfs/extent-tree.c | 8