Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Wang Shilong
On 05/14/2014 09:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Just out of curiosity, this option is used for what kind of use case? I notice Ext4 also has this option.:-) Signed-off-by: Eric

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Brendan Hide
On 14/05/14 09:31, Wang Shilong wrote: On 05/14/2014 09:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Just out of curiosity, this option is used for what kind of use case? I notice Ext4 also has

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Eric Sandeen
On 5/14/14, 2:31 AM, Wang Shilong wrote: On 05/14/2014 09:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Just out of curiosity, this option is used for what kind of use case? I notice Ext4 also has

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread David Pottage
On 14/05/14 08:31, Wang Shilong wrote: On 05/14/2014 09:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Just out of curiosity, this option is used for what kind of use case? I notice Ext4 also has

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Duncan
Brendan Hide posted on Wed, 14 May 2014 14:25:22 +0200 as excerpted: On 14/05/14 09:31, Wang Shilong wrote: On 05/14/2014 09:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Just out of curiosity,

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Goffredo Baroncelli
Hi Eric, On 05/14/2014 03:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. I suggest to add some warning when this options is used, because the behavior could be very different than the one expected. I suspect that BTRFS tracks the filesystem by UUID and

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Eric Sandeen
On 5/14/14, 9:39 AM, Goffredo Baroncelli wrote: Hi Eric, On 05/14/2014 03:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. I suggest to add some warning when this options is used, because the behavior could be very different than the one expected.

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread James Shubin
On Wed, 2014-05-14 at 14:25 +0200, Brendan Hide wrote: On 14/05/14 09:31, Wang Shilong wrote: On 05/14/2014 09:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Just out of curiosity, this option

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread James Shubin
On Wed, 2014-05-14 at 16:39 +0200, Goffredo Baroncelli wrote: Hi Eric, On 05/14/2014 03:18 AM, Eric Sandeen wrote: Allow the specification of the filesystem UUID at mkfs time. I suggest to add some warning when this options is used, because the behavior could be very different than the

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread Goffredo Baroncelli
On 05/14/2014 04:41 PM, Eric Sandeen wrote: I am not against this option; I am suggesting to add a explicit warning to the user about the risk of doing that, both on the man pages and into the program. The warning should say that this option is only for testing. Better ask for a confirmation

Re: [PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-14 Thread David Sterba
On Wed, May 14, 2014 at 09:41:19AM -0500, Eric Sandeen wrote: I am not against this option; I am suggesting to add a explicit warning to the user about the risk of doing that, both on the man pages and into the program. The warning should say that this option is only for testing. Better

[PATCH] mkfs.btrfs: allow UUID specification at mkfs time

2014-05-13 Thread Eric Sandeen
Allow the specification of the filesystem UUID at mkfs time. (Implemented only for mkfs.btrfs, not btrfs-convert). Signed-off-by: Eric Sandeen sand...@redhat.com --- diff --git a/btrfs-convert.c b/btrfs-convert.c index a8b2c51..d62d4f8 100644 --- a/btrfs-convert.c +++ b/btrfs-convert.c @@