Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2014-01-08 Thread Josef Bacik
On 01/08/2014 09:33 AM, David Sterba wrote: On Wed, Dec 18, 2013 at 04:07:28PM -0500, Josef Bacik wrote: /* - * btrfs_qgroup_record_ref is called when the ref is added or deleted. it puts - * the modification into a list that's later used by btrfs_end_transaction to - * pass the recorded

Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2014-01-08 Thread David Sterba
On Wed, Dec 18, 2013 at 04:07:28PM -0500, Josef Bacik wrote: /* - * btrfs_qgroup_record_ref is called when the ref is added or deleted. it puts - * the modification into a list that's later used by btrfs_end_transaction to - * pass the recorded modifications on to btrfs_qgroup_account_ref.

Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2014-01-07 Thread Josef Bacik
On 12/21/2013 03:56 AM, Wang Shilong wrote: Hello Josef, Though i know there are still problems related to qgroup(for example removing snapshot will beak qgroup accounting).I did a simple test about your patch.. # btrfs quota enable /mnt # dd if=/dev/zero of=/mnt/data bs=4k count=102400

Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2013-12-21 Thread Wang Shilong
Hello Josef, Though i know there are still problems related to qgroup(for example removing snapshot will beak qgroup accounting).I did a simple test about your patch.. # btrfs quota enable /mnt # dd if=/dev/zero of=/mnt/data bs=4k count=102400 oflag=direct # btrfs sub snapshot /mnt/ /mnt/snap1

Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2013-12-21 Thread Josef Bacik
On 12/21/2013 03:01 AM, Wang Shilong wrote: Hi Josef, I compie btrfs-next in my 32-bit machine, i get the following warnings: fs/btrfs/qgroup.c: In function ‘qgroup_excl_accounting’: fs/btrfs/qgroup.c:1503:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Re: [PATCH 2/3] Btrfs: rework qgroup accounting

2013-12-21 Thread Josef Bacik
On 12/21/2013 03:56 AM, Wang Shilong wrote: Hello Josef, Though i know there are still problems related to qgroup(for example removing snapshot will beak qgroup accounting).I did a simple test about your patch.. # btrfs quota enable /mnt # dd if=/dev/zero of=/mnt/data bs=4k count=102400