Re: [PATCH 5/5] Btrfs-progs: Validate super block checksum

2013-06-21 Thread David Sterba
On Thu, Jun 20, 2013 at 06:08:29PM +0100, Filipe David Manana wrote: Is there any reason why the btrfs progs (except for btrfs-show-super) don't validate the super block's checksum? btrfsck accepts broken filesystems, so open_ctree_broken should possibly detect but skip the checksum mismatch.

Re: [PATCH 5/5] Btrfs-progs: Validate super block checksum

2013-06-21 Thread Filipe David Manana
On Fri, Jun 21, 2013 at 5:18 PM, David Sterba dste...@suse.cz wrote: On Thu, Jun 20, 2013 at 06:08:29PM +0100, Filipe David Manana wrote: Is there any reason why the btrfs progs (except for btrfs-show-super) don't validate the super block's checksum? btrfsck accepts broken filesystems, so

Re: [PATCH 5/5] Btrfs-progs: Validate super block checksum

2013-06-20 Thread Filipe David Manana
Ping. Is there any reason why the btrfs progs (except for btrfs-show-super) don't validate the super block's checksum? thanks On Mon, Jun 10, 2013 at 8:51 PM, Filipe David Borba Manana fdman...@gmail.com wrote: After finding a super block in a device also validate its checksum. This

[PATCH 5/5] Btrfs-progs: Validate super block checksum

2013-06-10 Thread Filipe David Borba Manana
After finding a super block in a device also validate its checksum. This validation is done in the kernel but it was missing in btrfs-progs. The function btrfs_check_super_csum() is imported from the file fs/btrfs/disk-io.c in the kernel source tree. Signed-off-by: Filipe David Borba Manana