Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-14 Thread Andy Lutomirski
On Sep 13, 2015 4:25 PM, "Dave Chinner" wrote: > > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > > Can we have a clean way to figure out whether two file ranges are the > > same in a way that allows false negatives? I.e. return 1 if the > > ranges are

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-13 Thread Dave Chinner
On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > Can we have a clean way to figure out whether two file ranges are the > same in a way that allows false negatives? I.e. return 1 if the > ranges are reflinks of each other and 0 if not? Pretty please? I've > implemented that in

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-10 Thread Austin S Hemmelgarn
On 2015-09-09 14:52, Anna Schumaker wrote: On 09/08/2015 06:39 PM, Darrick J. Wong wrote: On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong wrote: On Tue, Sep 08, 2015 at 09:03:09PM +0100, Pádraig Brady

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-10 Thread Anna Schumaker
On 09/09/2015 05:16 PM, Darrick J. Wong wrote: > On Wed, Sep 09, 2015 at 02:52:08PM -0400, Anna Schumaker wrote: >> On 09/08/2015 06:39 PM, Darrick J. Wong wrote: >>> On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-10 Thread Austin S Hemmelgarn
On 2015-09-10 11:10, Anna Schumaker wrote: On 09/09/2015 05:16 PM, Darrick J. Wong wrote: On Wed, Sep 09, 2015 at 02:52:08PM -0400, Anna Schumaker wrote: On 09/08/2015 06:39 PM, Darrick J. Wong wrote: On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: On Tue, Sep 8, 2015 at

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Anna Schumaker
On 09/08/2015 06:39 PM, Darrick J. Wong wrote: > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: >> On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong >> wrote: >>> On Tue, Sep 08, 2015 at 09:03:09PM +0100, Pádraig Brady wrote: On 08/09/15 20:10, Andy

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Trond Myklebust
On Wed, Sep 9, 2015 at 4:09 PM, Chris Mason wrote: > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: >> On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong >> wrote: >> > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: >> >>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Andy Lutomirski
On Wed, Sep 9, 2015 at 1:09 PM, Chris Mason wrote: > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: >> On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong >> wrote: >> > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: >> >>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Chris Mason
On Wed, Sep 09, 2015 at 04:26:58PM -0400, Trond Myklebust wrote: > On Wed, Sep 9, 2015 at 4:09 PM, Chris Mason wrote: > > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > >> On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong > >> wrote: > >>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Anna Schumaker
On 09/09/2015 04:38 PM, Chris Mason wrote: > On Wed, Sep 09, 2015 at 04:26:58PM -0400, Trond Myklebust wrote: >> On Wed, Sep 9, 2015 at 4:09 PM, Chris Mason wrote: >>> On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: On Tue, Sep 8, 2015 at 3:39 PM, Darrick J.

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Chris Mason
On Wed, Sep 09, 2015 at 01:37:44PM -0700, Andy Lutomirski wrote: > On Wed, Sep 9, 2015 at 1:09 PM, Chris Mason wrote: > > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > >> On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong > >> wrote: > >>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Chris Mason
On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong > wrote: > > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: > >> What I meant by this was: if you ask for "regular copy", you may end > >>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Darrick J. Wong
On Wed, Sep 09, 2015 at 02:52:08PM -0400, Anna Schumaker wrote: > On 09/08/2015 06:39 PM, Darrick J. Wong wrote: > > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: > >> On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong > >> wrote: > >>> On Tue, Sep 08,

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Darrick J. Wong
On Wed, Sep 09, 2015 at 04:41:34PM -0400, Anna Schumaker wrote: > On 09/09/2015 04:38 PM, Chris Mason wrote: > > On Wed, Sep 09, 2015 at 04:26:58PM -0400, Trond Myklebust wrote: > >> On Wed, Sep 9, 2015 at 4:09 PM, Chris Mason wrote: > >>> On Tue, Sep 08, 2015 at 04:08:43PM -0700,

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Pádraig Brady
On 08/09/15 20:10, Andy Lutomirski wrote: > On Tue, Sep 8, 2015 at 11:23 AM, Anna Schumaker > wrote: >> On 09/08/2015 11:21 AM, Pádraig Brady wrote: >>> I see copy_file_range() is a reflink() on BTRFS? >>> That's a bit surprising, as it avoids the copy completely. >>>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Andy Lutomirski
On Tue, Sep 8, 2015 at 11:23 AM, Anna Schumaker wrote: > On 09/08/2015 11:21 AM, Pádraig Brady wrote: >> I see copy_file_range() is a reflink() on BTRFS? >> That's a bit surprising, as it avoids the copy completely. >> cp(1) for example considered doing a BTRFS clone by

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Anna Schumaker
On 09/08/2015 04:45 PM, Darrick J. Wong wrote: > On Tue, Sep 08, 2015 at 11:08:03AM -0400, Anna Schumaker wrote: >> On 09/05/2015 04:33 AM, Al Viro wrote: >>> On Fri, Sep 04, 2015 at 04:25:27PM -0600, Andreas Dilger wrote: >>> This is a bit of a surprising result, since in my testing in the

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Darrick J. Wong
On Tue, Sep 08, 2015 at 11:08:03AM -0400, Anna Schumaker wrote: > On 09/05/2015 04:33 AM, Al Viro wrote: > > On Fri, Sep 04, 2015 at 04:25:27PM -0600, Andreas Dilger wrote: > > > >> This is a bit of a surprising result, since in my testing in the > >> past, copy_{to/from}_user() is a major

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Darrick J. Wong
On Tue, Sep 08, 2015 at 09:03:09PM +0100, Pádraig Brady wrote: > On 08/09/15 20:10, Andy Lutomirski wrote: > > On Tue, Sep 8, 2015 at 11:23 AM, Anna Schumaker > > wrote: > >> On 09/08/2015 11:21 AM, Pádraig Brady wrote: > >>> I see copy_file_range() is a reflink() on

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Darrick J. Wong
On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: > On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong > wrote: > > On Tue, Sep 08, 2015 at 09:03:09PM +0100, Pádraig Brady wrote: > >> On 08/09/15 20:10, Andy Lutomirski wrote: > >> > On Tue, Sep 8, 2015 at

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Andy Lutomirski
On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong wrote: > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: >> On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong >> wrote: >> > On Tue, Sep 08, 2015 at 09:03:09PM +0100, Pádraig Brady

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Pádraig Brady
On 04/09/15 21:16, Anna Schumaker wrote: > Copy system calls came up during Plumbers a couple of weeks ago, because > several filesystems (including NFS and XFS) are currently working on copy > acceleration implementations. We haven't heard from Zach Brown in a while, > so I volunteered to push

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Darrick J. Wong
On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong > wrote: > > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: > >> On Tue, Sep 8, 2015 at 2:29 PM, Darrick J. Wong

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-08 Thread Anna Schumaker
On 09/04/2015 06:25 PM, Andreas Dilger wrote: > On Sep 4, 2015, at 2:16 PM, Anna Schumaker wrote: >> >> Copy system calls came up during Plumbers a couple of weeks ago, >> because several filesystems (including NFS and XFS) are currently >> working on copy acceleration

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-05 Thread Al Viro
On Fri, Sep 04, 2015 at 04:25:27PM -0600, Andreas Dilger wrote: > This is a bit of a surprising result, since in my testing in the > past, copy_{to/from}_user() is a major consumer of CPU time (50% > of a CPU core at 1GB/s). What backing filesystem did you test on? While we are at it, was cp(1)

[PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-04 Thread Anna Schumaker
Copy system calls came up during Plumbers a couple of weeks ago, because several filesystems (including NFS and XFS) are currently working on copy acceleration implementations. We haven't heard from Zach Brown in a while, so I volunteered to push his patches upstream so individual filesystems

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-04 Thread Andreas Dilger
On Sep 4, 2015, at 2:16 PM, Anna Schumaker wrote: > > Copy system calls came up during Plumbers a couple of weeks ago, > because several filesystems (including NFS and XFS) are currently > working on copy acceleration implementations. We haven't heard from > Zach