Re: [PATCH v2] btrfs-progs: btrfs-convert: Add larger device support

2017-06-01 Thread Lakshmipathi.G
> > I think we should use the 64bit types just to be safe. > Dave, Okay made those changes and new patch sent. >If we need to modify tons of things, then please split such modification to >different patches. Qu, Seems like only minor changes needed, so used a single patch. Cheers.

Re: [PATCH v2] btrfs-progs: btrfs-convert: Add larger device support

2017-05-30 Thread David Sterba
On Mon, May 15, 2017 at 02:06:54PM +0530, Lakshmipathi.G wrote: > On Mon, May 15, 2017 at 09:40:29AM +0800, Qu Wenruo wrote: > > >bug: https://bugzilla.kernel.org/show_bug.cgi?id=194795 > > > > Errr, it seems that you forgot to update ext2_open_fs() to update how we get > > cctx->block_counts. >

Re: [PATCH v2] btrfs-progs: btrfs-convert: Add larger device support

2017-05-15 Thread Lakshmipathi.G
On Mon, May 15, 2017 at 09:40:29AM +0800, Qu Wenruo wrote: > >bug: https://bugzilla.kernel.org/show_bug.cgi?id=194795 > > Errr, it seems that you forgot to update ext2_open_fs() to update how we get > cctx->block_counts. > > Without that update, we still get wrong total size of original fs, so >

[PATCH v2] btrfs-progs: btrfs-convert: Add larger device support

2017-05-13 Thread Lakshmipathi.G
With larger file system (in this case its 22TB), ext2fs_open() returns EXT2_ET_CANT_USE_LEGACY_BITMAPS error message with ext2fs_read_block_bitmap(). To overcome this issue, we need pass EXT2_FLAG_64BITS flag with ext2fs_open and also use 64-bit functions like ext2fs_get_block_bitmap_range2,