Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-05 Thread David Sterba
On Thu, Oct 05, 2017 at 09:57:25AM +0900, Misono, Tomohiro wrote: > > I agree with Andrei and Hugo. We need to check that the subvolume path > > belongs to the filesystem anyway. I don't see that in the first version, > > so please fix it. > > > > I'm a bit confusing, but what is the meaning of

Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-04 Thread Misono, Tomohiro
On 2017/10/05 3:07, David Sterba wrote: > On Tue, Oct 03, 2017 at 08:57:52AM +0900, Misono, Tomohiro wrote: >> On 2017/10/02 18:01, Hugo Mills wrote: >>> On Mon, Oct 02, 2017 at 11:39:05AM +0300, Andrei Borzenkov wrote: On Mon, Oct 2, 2017 at 11:19 AM, Misono, Tomohiro

Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-04 Thread David Sterba
On Tue, Oct 03, 2017 at 08:57:52AM +0900, Misono, Tomohiro wrote: > On 2017/10/02 18:01, Hugo Mills wrote: > > On Mon, Oct 02, 2017 at 11:39:05AM +0300, Andrei Borzenkov wrote: > >> On Mon, Oct 2, 2017 at 11:19 AM, Misono, Tomohiro > >> wrote: > >>> This patch

Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-02 Thread Misono, Tomohiro
On 2017/10/02 18:01, Hugo Mills wrote: > On Mon, Oct 02, 2017 at 11:39:05AM +0300, Andrei Borzenkov wrote: >> On Mon, Oct 2, 2017 at 11:19 AM, Misono, Tomohiro >> wrote: >>> This patch changes "subvol set-default" to also accept the subvolume path >>> for

Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-02 Thread Hugo Mills
On Mon, Oct 02, 2017 at 11:39:05AM +0300, Andrei Borzenkov wrote: > On Mon, Oct 2, 2017 at 11:19 AM, Misono, Tomohiro > wrote: > > This patch changes "subvol set-default" to also accept the subvolume path > > for convenience. > > > > This is the one of the issue on

Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-02 Thread Andrei Borzenkov
On Mon, Oct 2, 2017 at 11:19 AM, Misono, Tomohiro wrote: > This patch changes "subvol set-default" to also accept the subvolume path > for convenience. > > This is the one of the issue on github: > https://github.com/kdave/btrfs-progs/issues/35 > > If there are two

[PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path

2017-10-02 Thread Misono, Tomohiro
This patch changes "subvol set-default" to also accept the subvolume path for convenience. This is the one of the issue on github: https://github.com/kdave/btrfs-progs/issues/35 If there are two args, they are assumed as subvol id and path to the fs (the same as current behavior), and if there