Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread David Sterba
A different lockdep chain, from test btrfs/014: [ 229.850151] == [ 229.850788] [ INFO: possible circular locking dependency detected ] [ 229.850788] 3.15.0-rc7-default+ #146 Tainted: GW [ 229.850788]

Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 5/27/14, 7:26 AM, David Sterba wrote: A different lockdep chain, from test btrfs/014: Are you sure this one was with the new patch? We shouldn't be holding groups_sem anymore in btrfs_remove_block_group while performing the kobject ops. - -Jeff

Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread David Sterba
On Tue, May 27, 2014 at 08:14:11AM -0400, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 5/27/14, 7:26 AM, David Sterba wrote: A different lockdep chain, from test btrfs/014: Are you sure this one was with the new patch? We shouldn't be holding groups_sem anymore

Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Chris Mason
On 05/26/2014 09:35 PM, Jeff Mahoney wrote: We are currently allocating space_info objects in an array when we allocate space_info. When a user does something like: # btrfs balance start -mconvert=raid1 -dconvert=raid1 /mnt # btrfs balance start -mconvert=single -dconvert=single /mnt -f #

[PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-26 Thread Jeff Mahoney
We are currently allocating space_info objects in an array when we allocate space_info. When a user does something like: # btrfs balance start -mconvert=raid1 -dconvert=raid1 /mnt # btrfs balance start -mconvert=single -dconvert=single /mnt -f # btrfs balance start -mconvert=raid1 -dconvert=raid1