Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-23 Thread Lakshmipathi.G
> > Only recovery needs to be implemented now. > > Thanks, > Qu > Once recovery is implemented, I'll try again. Just one suggestion: Optionally, It is possible to print filename for these detected blocks. For ex, if corruption happened on a old/unwanted archived log file

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-23 Thread Lakshmipathi.G
Okay, I did multiple (upto 11) corruption on the same file. Seems like it says 'CORRUPTED' when we corrupt two continuous data stripes and reports 'RECOVERABLE' whenever possible.It looks fine. You can find the logs and test-scripts on below link. thanks.

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-22 Thread Lakshmipathi.G
Okay sure, When I find free-time, will run few more combinations and let you know the details along with any other suggestions/thoughts on the interface. thanks. On 5/22/17, Qu Wenruo wrote: > Good to hear that. > > And you could try more combination (although I have

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-22 Thread Lakshmipathi.G
Yes. It detects the injected corruption. #btrfs scrub start --offline /dev/loop6 ERROR: data at bytenr 145293312 mirror 0 csum mismatch, have 0x790f1fe1 expect 0xa30cb5c5 ERROR: full stripe 145227776 RECOVERABLE: Data stripes corrupted, but P/Q is good Scrub result: Tree bytes scrubbed: 131072

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-22 Thread Lakshmipathi.G
> > As the title said, it's *offline* scrub, while you're still using the > *online* scrub. > > To use offline scrub, you should exec "btrfs scrub start --offline > " > > And then it should detect the same error. > Output is nothing like kernel. > > Thanks, > Qu > Ah,my bad. I thought the entire

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-22 Thread Lakshmipathi.G
When I ran the script, it produces below output. From the output it looks like, it detected the error and corrected. But parity-block corruption fix patch not yet merged or I missed something? Run: (with scrub_offline repo) btrfs scrub start /home/laks/centos/laks/BTRFS/scrub_offline/tests/mnt

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-13 Thread Lakshmipathi.G
> > Ping? > > Any comments? > > Thanks, > Qu Can I inject corruption with existing script [1] and expect offline scrub to fix it? If so, I'll give it try and let you know the results. [1] https://patchwork.kernel.org/patch/9583455/ Cheers, Lakshmipathi.G -- To unsubscribe from this list:

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-12 Thread David Sterba
On Tue, May 09, 2017 at 01:46:04PM +0800, Qu Wenruo wrote: > Ping? > > Any comments? Sorry, no updates from me. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 00/19] Btrfs-progs offline scrub

2017-05-08 Thread Qu Wenruo
Ping? Any comments? Thanks, Qu At 03/30/2017 02:20 PM, Qu Wenruo wrote: For any one who wants to try it, it can be get from my repo: https://github.com/adam900710/btrfs-progs/tree/offline_scrub Several reports on kernel scrub screwing up good data stripes are in ML for sometime. And since

[PATCH v3 00/19] Btrfs-progs offline scrub

2017-03-30 Thread Qu Wenruo
For any one who wants to try it, it can be get from my repo: https://github.com/adam900710/btrfs-progs/tree/offline_scrub Several reports on kernel scrub screwing up good data stripes are in ML for sometime. And since kernel scrub won't account P/Q corruption, it makes us quite hard to detect