Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2014-01-08 Thread David Sterba
On Wed, Jan 08, 2014 at 02:25:02PM +0800, Qu Wenruo wrote: But according to the dmesg, which is expired now though, I made the following assumption: There is a possibility that out of order execution made the work-wq = wq sentence executed behind the queue_work() call, and the

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2014-01-08 Thread Qu Wenruo
On Wed, 8 Jan 2014 19:51:59 +0100, David Sterba wrote: On Wed, Jan 08, 2014 at 02:25:02PM +0800, Qu Wenruo wrote: But according to the dmesg, which is expired now though, I made the following assumption: There is a possibility that out of order execution made the work-wq = wq sentence executed

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2014-01-07 Thread Qu Wenruo
On Mon, 23 Dec 2013 10:35:04 +0800 , Qu Wenruo wrote: On fri, 20 Dec 2013 05:30:48 -0800, Josef Bacik wrote: On 12/19/2013 07:08 PM, Qu Wenruo wrote: I'm sorry but I failed to reproduce the problem. Btrfs/012 in xfstests has been run for serveral hours but nothing happened. Would you

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2013-12-22 Thread Qu Wenruo
On fri, 20 Dec 2013 05:30:48 -0800, Josef Bacik wrote: On 12/19/2013 07:08 PM, Qu Wenruo wrote: I'm sorry but I failed to reproduce the problem. Btrfs/012 in xfstests has been run for serveral hours but nothing happened. Would you please give me some more details about the environment or

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2013-12-20 Thread Josef Bacik
On 12/19/2013 07:08 PM, Qu Wenruo wrote: I'm sorry but I failed to reproduce the problem. Btrfs/012 in xfstests has been run for serveral hours but nothing happened. Would you please give me some more details about the environment or the panic backtrace? Ok so it wasn't that test, it

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2013-12-19 Thread Josef Bacik
I got a panic with btrfs/012 in the worker stuff. I'm bisecting it down to figure out which patch introduced it but I'm afraid it may just be one of the replace blah with btrfs_workqueue patches and not be super helpful. You may want to run it in a loop or something and see if you can

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2013-12-19 Thread Qu Wenruo
Thanks for reporting. That's interesting, I'll look into it to figure out what's happening. Qu On Thu, 19 Dec 2013 10:27:22 -0500, Josef Bacik wrote: I got a panic with btrfs/012 in the worker stuff. I'm bisecting it down to figure out which patch introduced it but I'm afraid it may just

Re: [PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2013-12-19 Thread Qu Wenruo
I'm sorry but I failed to reproduce the problem. Btrfs/012 in xfstests has been run for serveral hours but nothing happened. Would you please give me some more details about the environment or the panic backtrace? Thanks. Qu On Thu, 19 Dec 2013 10:27:22 -0500, Josef Bacik wrote: I got a

[PATCH v4 00/18] Replace btrfs_workers with kernel workqueue based btrfs_workqueue

2013-12-17 Thread Qu Wenruo
Add a new btrfs_workqueue_struct which use kernel workqueue to implement most of the original btrfs_workers, to replace btrfs_workers. With this patchset, redundant workqueue codes are replaced with kernel workqueue infrastructure, which not only reduces the code size but also the effort to