If I have a filesystem that shows this...

rw,relatime,ssd,space_cache=v2,subvolid=5,subvol=/

...and then I do this...

-# mount -o remount,nossd /mnt/btrfs/

...then it shows...

rw,relatime,nossd,space_cache=v2,subvolid=5,subvol=/

...but when I do this...

-# mount -o remount,ssd /mnt/btrfs/

...it ends up with a rotational identity crisis:

rw,relatime,nossd,ssd,space_cache=v2,subvolid=5,subvol=/
            ^^^^^ ^^^

The only thing the nossd option does when mounting first time is
preventing that ssd gets enabled automatically. When doing nossd with
remount, it clears out the ssd flag, but telling it to ssd again does
not clear the nossd flag.

The actual kernel code which changes behaviour based on these options
only ever checks for SSD, never for NOSSD.

So, the situation does not lead to any wrong behaviour right now, but
it's confusing, and it could be a source of bugs in the future, when
anything would test for NOSSD explicitely and make a decision based on
the result.

Moo,
-- 
Hans van Kranenburg
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to