Confirmed the fix is working.
^ TLDR can stop here :)
Recompiled the original Archlinux package from newly-synced ABS but also
with your patch. I then tested the newly-compiled btrfs with the patch.
I realised after I should have also tested immediately before installing
the patched version,
Brendan,
---
[root@watricky mnt]# btrfs subvolume list / -a
ID 258 gen 4226 top level 384 path media/smbshare
::
[root@watricky mnt]# btrfs subvolume list /home -a
ID 258 gen 4226 top level 5 path
FS_TREE/__active/media/smbshare4.snap
---
This is definitely a bug. Thanks