Re: [PATCH] clk: rockchip: only enter pll slow-mode directly before reboots on rk3288

Heiko, On Fri, Dec 18, 2015 at 10:33 AM, Heiko Stübner wrote: > As commit 1d33929e2a2b ("clk: rockchip: switch PLLs to slow mode before > reboot for rk3288") states, switching the PLLs to slow-mode is only > necessary when rebooting using the soft-reset done through the CRU. > > The dwc2 controll

Re: [PATCH v2 4/8] mmc: dw_mmc: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch

Kevin, On Fri, Oct 9, 2015 at 12:06 PM, Kevin Hilman wrote: > On Wed, Sep 30, 2015 at 4:07 PM, Heiko Stuebner wrote: >> From: Douglas Anderson >> >> We've introduced a new helper in the MMC core: >> mmc_regulator_set_vqmmc(). Let's use this in dw_mmc. Using this new >> helper has some advanta

Re: [PATCH v2 0/8] mmc: dw_mmc-rockchip: allow tuning using the clk-phase api

Hi, On Fri, Oct 9, 2015 at 10:19 AM, Doug Anderson wrote: > Hi, > > On Fri, Oct 9, 2015 at 1:10 AM, Ulf Hansson wrote: >> Dough, Heiko, >> >> This patchset seems to be causing a boot regression for exynos5800-peach-pi >> [1]. >> >> Apparently, th

Re: [PATCH v2 0/8] mmc: dw_mmc-rockchip: allow tuning using the clk-phase api

Hi, On Fri, Oct 9, 2015 at 1:10 AM, Ulf Hansson wrote: > Dough, Heiko, > > This patchset seems to be causing a boot regression for exynos5800-peach-pi > [1]. > > Apparently, the vmmc regulator doesn't exist for one of the controller > but vqmmc is. This leads to the following NULL pointer except

Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

Ulf, On Wed, Sep 2, 2015 at 4:38 AM, Ulf Hansson wrote: >> +/** >> + * mmc_regulator_set_vqmmc - Set VQMMC as per the ios >> + * >> + * For 3.3V signaling, we try to match VQMMC to VMMC as closely as possible. > > Looking at the code, I don't think this statement is entirely true. > Isn't it so t