Re: [RFC 6/9] clk: ti: add support for omap4 module clocks

2016-01-04 Thread Tony Lindgren
* Russell King - ARM Linux [160104 06:43]: > On Mon, Jan 04, 2016 at 03:27:57PM +0200, Tero Kristo wrote: > > On 01/04/2016 12:21 PM, Geert Uytterhoeven wrote: > > >FWIW, there are small loops with just a cpu_relax() in various clock > > >drivers > > >under drivers/clk/shmobile/. > > > > Just di

Re: [PATCH v4] clk: ti: Add support for dm814x ADPLL

2015-12-22 Thread Tony Lindgren
* Michael Turquette [151222 12:56]: > On 12/22, Tony Lindgren wrote: > > * Tero Kristo [151222 12:28]: > > > On 12/22/2015 05:27 PM, Tony Lindgren wrote: > > > >On dm814x we have 13 ADPLLs with 3 to 4 outputs on each. The > > > >ADPLLs have several

Re: [PATCH v4] clk: ti: Add support for dm814x ADPLL

2015-12-22 Thread Tony Lindgren
* Tero Kristo [151222 12:28]: > On 12/22/2015 05:27 PM, Tony Lindgren wrote: > >On dm814x we have 13 ADPLLs with 3 to 4 outputs on each. The > >ADPLLs have several dividers and muxes controlled by a shared > >control register for each PLL. > > > >Note that for the

[PATCH v4] clk: ti: Add support for dm814x ADPLL

2015-12-22 Thread Tony Lindgren
ls to postcore_initcall". Also note that this patch does not implement clk_set_rate for the PLL, that will be posted later on when available. Cc: Michael Turquette Cc: Stephen Boyd Cc: Tero Kristo Signed-off-by: Tony Lindgren --- If no more comments, Tero can you please apply into an immuta

Re: [PATCH v3] clk: ti: Add support for dm814x ADPLL

2015-12-21 Thread Tony Lindgren
* Tony Lindgren [151215 13:02]: > On dm814x we have 13 ADPLLs with 3 to 4 outputs on each. The > ADPLLs have several dividers and muxes controlled by a shared > control register for each PLL. > > Note that for the clocks to work as device drivers for booting on > dm814x, thi

Re: [RFC 6/9] clk: ti: add support for omap4 module clocks

2015-12-18 Thread Tony Lindgren
* Tero Kristo [151218 05:57]: > Previously, hwmod core has been used for controlling the hwmod level > clocks. This has certain drawbacks, like being unable to share the > clocks for multiple users, missing usecounting and generally being > totally incompatible with common clock framework. > > Ad

Re: [RFC 8/9] ARM: OMAP4: hwmod_data: use module clocks from DT

2015-12-18 Thread Tony Lindgren
* Tero Kristo [151218 05:57]: > Replace the usage of prcm->clkstctrl with main_clk:s provided via DT. > This is done in preparation to get rid of hwmod data from kernel. ... > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > @@ -334,10 +329,9 @@

Re: [RFC 1/9] ARM: OMAP2+: omap_device: create clock alias purely from DT data

2015-12-18 Thread Tony Lindgren
* Tero Kristo [151218 05:57]: > This avoids the need to add most of the clock aliases under > drivers/clk/ti/clk-xyz.c files. Yup is badly needed. Right now we have strange hidden dependencies in multiple subsystems to enable a single device driver: 1. Add a clock alias for a device 2. Add hwmod

Re: [RFC 7/9] ARM: dts: omap4: add hwmod module clocks

2015-12-18 Thread Tony Lindgren
* Tero Kristo [151218 05:57]: > + mmu_dsp_mod_ck: mmu_dsp_mod_ck { > + #clock-cells = <0>; > + compatible = "ti,omap4-hw-mod-clock"; > + reg = <0x0420>; > + clocks = <&dpll_iva_m4x2_ck>; > + }; > + > + dsp_mod_ck: dsp_mod_ck { > +

Re: [PATCHv2] clk: ti: omap5+: dpll: implement errata i810

2015-12-16 Thread Tony Lindgren
otential problems with earlier generation > SoCs also. > > Signed-off-by: Tero Kristo > --- > v2: made the fix to be applied unconditionally on all OMAP3+ SoCs Thanks looks good to me now: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubsc

[PATCH v3] clk: ti: Add support for dm814x ADPLL

2015-12-15 Thread Tony Lindgren
ls to postcore_initcall". Also note that this patch does not implement clk_set_rate for the PLL, that will be posted later on when available. Cc: Michael Turquette Cc: Stephen Boyd Cc: Tero Kristo Signed-off-by: Tony Lindgren --- Changes from v2 to v3 are listed below, hopefully I

Re: [PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-14 Thread Tony Lindgren
* Matthijs van Duin [151214 01:16]: > On Thu, Dec 10, 2015 at 06:26:32PM -0800, Tony Lindgren wrote: > > +- compatible : shall be one of "ti,dm814-adpll-s-clock" or > > + "ti,dm814-adpll-j-clock" depending on the type of the ADPLL > > There's sti

Re: [PATCH] clk: ti: omap5+: dpll: implement errata i810

2015-12-11 Thread Tony Lindgren
* Tero Kristo [151211 00:42]: > On 12/03/2015 06:48 PM, Tony Lindgren wrote: > >* Tero Kristo [151130 06:44]: > >>+ /* > >>+* Errata i810 - DPLL controller can get stuck while transitioning > >>+* to a power saving state. Software must ensure the DPL

Re: [PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-11 Thread Tony Lindgren
* Russell King - ARM Linux [151211 08:16]: > On Fri, Dec 11, 2015 at 07:48:54AM -0800, Tony Lindgren wrote: > > There's a problem with MAX_CON_ID 16 hardcoded allocated name length. > > Absolutely right... Well adding the warning there allows people to at least see what'

Re: [PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-11 Thread Tony Lindgren
* Tero Kristo [151210 23:45]: > On 12/11/2015 04:26 AM, Tony Lindgren wrote: > > Looks mostly good to me, added some minor comments inline below. Sorry again > for latencies in my replies. No problme, thanks for looking. > >+static bool ti_adpll_clock_is_bypass(struc

Re: [PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-11 Thread Tony Lindgren
* Russell King - ARM Linux [151211 05:53]: > On Thu, Dec 10, 2015 at 06:26:32PM -0800, Tony Lindgren wrote: > > + /* Released with kfree() by clkdev_drop() */ > > + cl = kzalloc(sizeof(*cl), GFP_KERNEL); > > + if (!cl) > > + return -ENOMEM; >

[PATCH v2] clk: ti: Add support for dm814x ADPLL

2015-12-10 Thread Tony Lindgren
ls to postcore_initcall". Also note that this patch does not implement clk_set_rate, that will be posted later on when available. Signed-off-by: Tony Lindgren --- Updated to use adpll_lj and adpll_s naming and s/FAPLL/ADPLL/ in the documentation as suggested by Matthijs. If no other comments

Re: [PATCH 1/2] clk: ti: Add support for dm814x ADPLL

2015-12-10 Thread Tony Lindgren
Hi, * Tony Lindgren [151203 08:08]: > * Tony Lindgren [151202 17:36]: > > On dm814x we have 13 ADPLLs with 3 to 4 outputs on each. The > > ADPLLs have several dividers and muxes controlled by a shared > > control register for each PLL. > > > > Note that for the

Re: [PATCH] clk: ti: omap5+: dpll: implement errata i810

2015-12-03 Thread Tony Lindgren
* Tero Kristo [151130 06:44]: > + /* > + * Errata i810 - DPLL controller can get stuck while transitioning > + * to a power saving state. Software must ensure the DPLL can not > + * transition to a low power state while changing M/N values. > + * Easiest way to accomplish t

Re: [PATCH 1/2] clk: ti: Add support for dm814x ADPLL

2015-12-03 Thread Tony Lindgren
* Tony Lindgren [151202 17:36]: > On dm814x we have 13 ADPLLs with 3 to 4 outputs on each. The > ADPLLs have several dividers and muxes controlled by a shared > control register for each PLL. > > Note that for the clocks to work as device drivers for booting on > dm814x, thi

[PATCH 2/2] ARM: dts: Add clocks for dm814x ADPLL

2015-12-02 Thread Tony Lindgren
These use the standard clock bindings and now we can make some of the fixed clocks into real clocks. Cc: Tero Kristo Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/dm814x-clocks.dtsi | 256 ++- 1 file changed, 225 insertions(+), 31 deletions(-) diff --git a

[PATCH 1/2] clk: ti: Add support for dm814x ADPLL

2015-12-02 Thread Tony Lindgren
ls to postcore_initcall". Also note that this patch does not implement clk_set_rate, that will be posted later on when available. Cc: Tero Kristo Signed-off-by: Tony Lindgren --- .../devicetree/bindings/clock/ti/adpll.txt | 42 + drivers/clk/Kconfig

[PATCH 0/2] Clock driver for dm814x ADPLL

2015-12-02 Thread Tony Lindgren
nux-omap&m=144901336001085&w=2 And also make sure you have the initcall level change patch that is needed for having omap clock drivers regular Linux device drivers: http://marc.info/?l=linux-omap&m=14489008207&w=2 Regards, Tony Tony Lindgren (2): clk: ti: Add support for dm

Re: [PATCH 2/4] clk: ti816x: Add missing dmtimer clkdev entries

2015-10-23 Thread Tony Lindgren
* Neil Armstrong [151022 02:19]: > Add missing clkdev dmtimer related entries for dm816x. > 32Khz and ext sources were missing. > > Cc: Brian Hutchinson > Signed-off-by: Neil Armstrong Tero should queue this one: Acked-by: Tony Lindgren > --- > drivers/clk/ti/clk-81

Re: [PATCH] clk: ti: fix dual-registration of uart4_ick

2015-10-05 Thread Tony Lindgren
* Tero Kristo [151005 05:39]: > On 10/05/2015 01:17 PM, Tony Lindgren wrote: > >* Ben Dooks [150929 06:14]: > >>On 25/09/15 06:42, Tero Kristo wrote: > >>>On 09/23/2015 08:30 PM, Tony Lindgren wrote: > >>>>* Ben Dooks [150923 07:53]: > >

Re: [PATCH] clk: ti: fix dual-registration of uart4_ick

2015-10-05 Thread Tony Lindgren
* Ben Dooks [150929 06:14]: > On 25/09/15 06:42, Tero Kristo wrote: > > On 09/23/2015 08:30 PM, Tony Lindgren wrote: > >> * Ben Dooks [150923 07:53]: > >>> On the OMAP AM3517 platform the uart4_ick gets registered > >>> twice, causing any power managme

Re: [PATCH] clk: ti: fix dual-registration of uart4_ick

2015-09-23 Thread Tony Lindgren
linefetch (0x1028) at 0xfa09e008 > [] PC is at serial_omap_pm+0x48/0x15c > [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c No uart4 on 34xx/35xx, that got introduced with 36xx so: Acked-by: Tony Lindgren > Signed-off-by: Ben Dooks > --- > drivers/clk/ti/clk-3xxx.c | 1 - > 1 file c

Re: [PATCH] clk: ti: Fix FAPLL udelay in clk_enable with clk_prepare

2015-09-23 Thread Tony Lindgren
* Peter Ujfalusi [150922 23:17]: > Tony, > > On 09/23/2015 12:23 AM, Tony Lindgren wrote: > > As recently pointed out (again) by Thomas and Russell, we must not > > wait in in clk_enable. The wait for PLL to lock needs to happen > > in clk_prepare instead. > > &

[PATCH] clk: ti: Fix FAPLL udelay in clk_enable with clk_prepare

2015-09-22 Thread Tony Lindgren
: Brian Hutchinson Cc: Felipe Balbi Cc: Grygorii Strashko Cc: Nishanth Menon Cc: Russell King - ARM Linux Cc: Thomas Gleixner Cc: Sekhar Nori Signed-off-by: Tony Lindgren --- drivers/clk/ti/fapll.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers