Re: [PATCH 06/13] clk: versatile-icst: convert to use regmap

2015-10-27 Thread Linus Walleij
On Fri, Oct 23, 2015 at 6:24 PM, Stephen Boyd wrote: > On 10/23, Linus Walleij wrote: >> On Thu, Oct 15, 2015 at 9:08 PM, Stephen Boyd wrote: >> > On 10/15, Linus Walleij wrote: >> >> @@ -151,10 +174,19 @@ struct clk *icst_clk_register(struct device *dev, >> >> init.flags = CLK_IS_ROOT; >>

Re: [PATCH 06/13] clk: versatile-icst: convert to use regmap

2015-10-23 Thread Stephen Boyd
On 10/23, Linus Walleij wrote: > On Thu, Oct 15, 2015 at 9:08 PM, Stephen Boyd wrote: > > On 10/15, Linus Walleij wrote: > >> @@ -151,10 +174,19 @@ struct clk *icst_clk_register(struct device *dev, > >> init.flags = CLK_IS_ROOT; > >> init.parent_names = (parent_name ? &parent_name : NU

Re: [PATCH 06/13] clk: versatile-icst: convert to use regmap

2015-10-23 Thread Linus Walleij
On Fri, Oct 23, 2015 at 11:27 AM, Linus Walleij wrote: > On Thu, Oct 15, 2015 at 9:08 PM, Stephen Boyd wrote: >> On 10/15, Linus Walleij wrote: >>> @@ -151,10 +174,19 @@ struct clk *icst_clk_register(struct device *dev, >>> init.flags = CLK_IS_ROOT; >>> init.parent_names = (parent_nam

Re: [PATCH 06/13] clk: versatile-icst: convert to use regmap

2015-10-23 Thread Linus Walleij
On Thu, Oct 15, 2015 at 9:08 PM, Stephen Boyd wrote: > On 10/15, Linus Walleij wrote: >> @@ -151,10 +174,19 @@ struct clk *icst_clk_register(struct device *dev, >> init.flags = CLK_IS_ROOT; >> init.parent_names = (parent_name ? &parent_name : NULL); >> init.num_parents = (parent_

Re: [PATCH 06/13] clk: versatile-icst: convert to use regmap

2015-10-15 Thread Stephen Boyd
On 10/15, Linus Walleij wrote: > @@ -151,10 +174,19 @@ struct clk *icst_clk_register(struct device *dev, > init.flags = CLK_IS_ROOT; > init.parent_names = (parent_name ? &parent_name : NULL); > init.num_parents = (parent_name ? 1 : 0); > + icst->map = regmap_init_mmio(NULL, ba

[PATCH 06/13] clk: versatile-icst: convert to use regmap

2015-10-15 Thread Linus Walleij
Instead of passing around register bases, pass around a regmap in this driver. This refactoring make things so much easier when we later want to manage an ICST that is part of a syscon. Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Signed-off-by: Linus Walleij --- I'm loo