Hello,
On Fri, Sep 01, 2006 at 01:52:25PM +1000, Herbert Xu wrote:
> On Thu, Aug 31, 2006 at 02:39:30PM +0200, Rik Snel wrote:
> > This is an attempt at implementing LRW for the new blockcipher API.
> > Please review, test and comment.
>
> Thanks a lot for doing this. It looks good to me.
That
On Fri, Sep 01, 2006 at 10:55:14AM +0200, [EMAIL PROTECTED] wrote:
>
> Can you give some examples about what I missed from CodingStyle?
> (I just reread it and I think my patch adheres pretty well to those
> rules: tabs=8, K&R bracing, don't pollute global namespace etc...)
It's only a few spots:
From: Rik Snel <[EMAIL PROTECTED]>
Main module, this implements the Liskov Rivest Wagner block cipher mode
in the new blockcipher API. The implementation is based on ecb.c.
The LRW-32-AES specification I used can be found at:
http://grouper.ieee.org/groups/1619/email/pdf00017.pdf
It implements t
From: Rik Snel <[EMAIL PROTECTED]>
128bit is a common blocksize in linux kernel cryptography, so it helps to
centralize some common operations. The data must be aligned at sizeof(int)
for decent performance.
The code, while mostly trivial, is based on a header file mode_hdr.h in
http://fp.gladman
From: Rik Snel <[EMAIL PROTECTED]>
Do modprobe tcrypt mode=10 to check the included test vectors, they are
from: http://grouper.ieee.org/groups/1619/email/pdf00017.pdf and from
http://www.mail-archive.com/stds-p1619@listserv.ieee.org/msg00173.html.
To make the last test vector fit, I had to incre
From: Rik Snel <[EMAIL PROTECTED]>
Just some minor comment nits.
- little-endian is better than low-endian
- and since it is called essiv everywere it should also be essiv
in the comments (and not ess_iv)
Signed-off-by: Rik Snel <[EMAIL PROTECTED]>
---
drivers/md/dm-crypt.c |8
1
From: Rik Snel <[EMAIL PROTECTED]>
LRW-32-AES needs a certain IV. This IV should be provided dm-crypt.
The block cipher mode could, in principle generate the correct IV from
the plain IV, but I think that it is cleaner to supply the right IV
directly.
The sector -> narrow block calculation uses a
From: Rik Snel <[EMAIL PROTECTED]>
WARNING: untested on bigendian, please test.
A lot of cypher modes need multiplications in GF(2^128). LRW, ABL, GCM...
I use functions from this library in my LRW implementation and I will
also use them in my ABL (Arbitrary Block Length, an unencumbered (correct
Hello Herbert/list,
Here is the updated version of my LRW patch set.
Greetings,
Rik.
--
VGER BF report: U 0.476584
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-
