Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page

2007-09-07 Thread Herbert Xu
On Fri, Sep 07, 2007 at 05:09:17PM -0700, Bob Gilligan wrote: > > Proposed patch is below. We found the problem and tested this fix in > 2.6.20, but it looks like the relevant code in blkcipher.c is the same > in the latest tree. Good catch! I've fixed this slightly differently. Also, the kmall

Re: [PATCH] an XTS blockcipher mode implementation without partial blocks

2007-09-07 Thread rsnel
Hello, On Fri, Sep 07, 2007 at 08:38:32PM +0200, Sebastian Siewior wrote: > [...] > > >Christoph encountered a deadlock after a few hours and 16GB of data (on > >an aes-xts-plain partition). Assuming there is an error in xts.c, is > >there an obvious way of finding it? > > Haven't seen any locks

Re: [PATCH] an XTS blockcipher mode implementation without partial blocks

2007-09-07 Thread Sebastian Siewior
* [EMAIL PROTECTED] | 2007-09-06 16:57:26 [+0200]: >> The compiler should generate similar code. > >I'd rather tell the compiler what I want than to introduce a new local >variable and a conditional branch in the hope that the compiler will >optimize it away, just to avoid a goto. > >If you insist