Hi Herbert,
On Nov 15, 2007 9:18 AM, Herbert Xu <[EMAIL PROTECTED]> wrote:
> Actually what I suggested is that you add a wrapper called
> salsa20 that then simply calls ctr(...) after constructing the IV.
I tried that but encountered a problem: what is the blocksize for the
underlying salsa20 expa
On Fri, Nov 16, 2007 at 02:42:24PM +0300, Evgeniy Polyakov wrote:
>
> > Actually on second thought why don't we change the interface
> > for ablkcipher so that we allow the IV to be returned by either
> > copying it to req->info or replacing the req->info pointer?
>
> Better copy I think, since ot
On Fri, Nov 16, 2007 at 07:25:30PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote:
> On Fri, Nov 16, 2007 at 02:11:10PM +0300, Evgeniy Polyakov wrote:
> >
> > That's a question - should it copy IV back or not?
> > Currently it is not required by crypto users.
>
> Well currently we have exactly one cr
On Fri, Nov 16, 2007 at 02:11:10PM +0300, Evgeniy Polyakov wrote:
>
> That's a question - should it copy IV back or not?
> Currently it is not required by crypto users.
Well currently we have exactly one crypto user of ablkcipher
in the tree, and that's tcrypt :)
However, looking at the sync cryp
On Fri, Nov 16, 2007 at 10:08:51AM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote:
> > So a general question: Is it a must (requirement by the crypto API) to
> > copy the IV back or not? I guess not if we move completely to async (one
> > day) :)
>
> You must copy it back to allow chaining. Even whe
On Fri, Nov 16, 2007 at 09:19:13AM +0100, Sebastian Siewior wrote:
> Not only in hfin. My SPU-AES has the same bug. Do you know someone who
> wants to chain? I can remember that you said once "that this is
> currently the case but we can change this since IPsec brings a new IV
> for ever packet".
>
* Herbert Xu | 2007-11-16 10:08:51 [+0800]:
>You must copy it back to allow chaining. Even when we go async
>someone may wish to chain. So in that sense you've just found a
>bug in the hifn driver :)
Not only in hfin. My SPU-AES has the same bug. Do you know someone who
wants to chain? I can rem
