Re: [PATCH 0/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-04 Thread Neil Horman
On Fri, Jul 04, 2008 at 10:44:15AM +0200, Sebastian Siewior wrote: > * Neil Horman | 2008-07-03 22:10:28 [-0400]: > > >On Fri, Jul 04, 2008 at 01:36:33AM +0200, Andi Kleen wrote: > >> Sebastian Siewior <[EMAIL PROTECTED]> writes: > >> > > >> > Anything wrong with get_random_bytes()? > >> > Whats t

Re: [PATCH] crypto: use kernel-provided bitops, unaligned access helpers

2008-07-04 Thread Herbert Xu
On Thu, Jul 03, 2008 at 02:03:57PM -0700, Harvey Harrison wrote: > Remove the private implementation of 32-bit rotation and unaligned > access with byteswapping. > > As a bonus, fixes sparse warnings: > crypto/camellia.c:602:2: warning: cast to restricted __be32 > crypto/camellia.c:603:2: warning:

Re: [PATCH 0/2] RNG: Add Pseudo Random Number Generator to kernel

2008-07-04 Thread Sebastian Siewior
* Neil Horman | 2008-07-03 22:10:28 [-0400]: >On Fri, Jul 04, 2008 at 01:36:33AM +0200, Andi Kleen wrote: >> Sebastian Siewior <[EMAIL PROTECTED]> writes: >> > >> > Anything wrong with get_random_bytes()? >> > Whats the advantage over get_random_bytes()? >> >> get_random_bytes() is not a _pseudo_