Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode

2009-06-18 Thread Huang Ying
On Thu, 2009-06-18 at 19:40 +0800, Herbert Xu wrote: > On Mon, Jun 15, 2009 at 05:04:57PM +0800, Huang Ying wrote: > > Because AES-NI instructions will touch XMM state, corresponding code > > must be enclosed within kernel_fpu_begin/end, which used > > preempt_disable/enable. So sleep should be pre

Re: [PATCH] crypto: s390 des3 - permit weak keys unless REQ_WEAK_KEY set

2009-06-18 Thread Herbert Xu
On Mon, Jun 08, 2009 at 01:32:09PM -0400, Jarod Wilson wrote: > Just started running fips cavs test vectors through an s390x system > for giggles, and discovered that I missed patching s390's arch-specific > des3 implementation w/an earlier des3 patch to permit weak keys. > > This change adds the

Re: [PATCH] crypto: add optional continuous repetition test to entropy store based rngs

2009-06-18 Thread Herbert Xu
On Fri, Jun 12, 2009 at 11:31:11AM -0500, Matt Mackall wrote: > > Acked-by: Matt Mackall Patch applied to cryptodev. Thanks everyone. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~

Re: [BUGFIX 1/3] crypto: Fix AES-NI cbc mode IV saving

2009-06-18 Thread Herbert Xu
On Mon, Jun 15, 2009 at 05:04:44PM +0800, Huang Ying wrote: > Original implementation of aesni_cbc_dec do not save IV if input > length % 4 == 0. This will make decryption of next block failed. > > Signed-off-by: Huang Ying All three patches applied to crypto-2.6. Thanks, -- Visit Openswan at

Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode

2009-06-18 Thread Herbert Xu
On Mon, Jun 15, 2009 at 05:04:57PM +0800, Huang Ying wrote: > Because AES-NI instructions will touch XMM state, corresponding code > must be enclosed within kernel_fpu_begin/end, which used > preempt_disable/enable. So sleep should be prevented between > kernel_fpu_begin/end. > > Signed-off-by: Hu

Re: [PATCH] AMCC Crypto4xx Device Driver v7

2009-06-18 Thread Herbert Xu
On Tue, Jun 09, 2009 at 02:21:38PM -0700, Shasi Pulijala wrote: > > diff --git a/crypto/md5.c b/crypto/md5.c > index 83eb529..0c74b84 100644 > --- a/crypto/md5.c > +++ b/crypto/md5.c > @@ -220,6 +220,21 @@ static int md5_final(struct shash_desc *desc, u8 *out) > return 0; > } > > +void md5

Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-18 Thread Huang Ying
On Thu, 2009-06-18 at 15:27 +0800, Sebastian Andrzej Siewior wrote: > * Huang Ying | 2009-06-18 10:08:27 [+0800]: > > >On Thu, 2009-06-18 at 04:04 +0800, Sebastian Andrzej Siewior wrote: > >> >+#include > >> >+#include > >> >+#include > >> >+#include > >> >+#include > >> >+#include > >> >+#i

Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-18 Thread Sebastian Andrzej Siewior
* Huang Ying | 2009-06-18 10:08:27 [+0800]: >On Thu, 2009-06-18 at 04:04 +0800, Sebastian Andrzej Siewior wrote: >> >+#include >> >+#include >> >+#include >> >+#include >> >+#include >> >+#include >> >+#include >> Do you mind to sort them? > >Sorry, can you tell me what is the better order?