On Tue, Jul 21, 2009 at 09:07:25PM +0800, Herbert Xu wrote:
On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote:
I just noticed that your shash version of hmac keeps the paded keys
on the transform. I assumed the hashing to be reentrant, so I
removed the locks arround the hash
On Wed, Jul 22, 2009 at 02:53:02PM +0200, Steffen Klassert wrote:
crypto_init_shash_ops_async() tests for setkey and not for import
before exporting the algorithms import function to ahash.
This patch fixes this.
Signed-off-by: Steffen Klassert steffen.klass...@secunet.com
Patch applied.
On Wed, Jul 22, 2009 at 05:57:03PM +0300, Phil Carmody wrote:
It's undefined behaviour in C to write outside the bounds of an array.
The key expansion routine takes a shortcut of creating 8 words at a
time, but this creates 4 additional words which don't fit in the array.
As everyone is
