Re: [PATCH 2/2] crypto: pcrypt - Add pcrypt crypto parallelization wrapper

2009-10-30 Thread Steffen Klassert
On Thu, Oct 08, 2009 at 11:18:33PM -0700, David Miller wrote: Steffen are we going to end up adding a softirq for every crypto transform type? That won't work, softirqs are to be scarcely allocated and operate at a very high level. I changed padata to use workqueues instead of softirqs

Re: [PATCH 2/2] crypto: pcrypt - Add pcrypt crypto parallelization wrapper

2009-10-30 Thread Herbert Xu
On Fri, Oct 30, 2009 at 11:06:09AM +0100, Steffen Klassert wrote: If we use tunnel mode, xfrm_input() calls netif_rx() which is certainly wrong if we are in thread context, we need to call netif_rx_ni() instead. Since this is all happening through a crypto completion call, it needs to be done

Re: [PATCH 2/2] crypto: pcrypt - Add pcrypt crypto parallelization wrapper

2009-10-30 Thread Steffen Klassert
On Fri, Oct 30, 2009 at 08:58:18AM -0400, Herbert Xu wrote: Since this is all happening through a crypto completion call, it needs to be done with BH off since that's a requirement for crypto completion functions. So netif_rx will work correctly as when BH is reenabled it'll pick up the

Re: [PATCH 2/2] crypto: pcrypt - Add pcrypt crypto parallelization wrapper

2009-10-30 Thread Herbert Xu
On Fri, Oct 30, 2009 at 02:27:34PM +0100, Steffen Klassert wrote: Ok, if it's required that BHs are off then everything is fine. In fact I solved this problem for pcrypt by switching off the BHs. I just was not sure whether this is the right way to do. Yeah having random contexts for