Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-02 Thread Huang Ying
On Mon, 2009-11-02 at 22:32 +0800, Ingo Molnar wrote: > * Herbert Xu wrote: > > > On Mon, Nov 02, 2009 at 08:50:39AM +0100, Ingo Molnar wrote: > > > > > > A cleanup request: mind creating two macros for this PSHUFB MMX/SSE > > > instruction in arch/x86/include/asm/i387.h, instead of open-codin

[BUGFIX for crypto-dev] crypto, Fix irq_fpu_usable usage in clmulni-intel

2009-11-02 Thread Huang Ying
When renaming kernel_fpu_using to irq_fpu_usable, the semantics of the function is changed too, from mesuring whether kernel is using FPU, that is, the FPU is NOT available, to measuring whether FPU is usable, that is, the FPU is available. But the usage of irq_fpu_usable in ghash-clmulni-intel_gl

[BUGFIX for .32] crypto, gcm, fix another complete call in complete fuction

2009-11-02 Thread Huang Ying
The flow of the complete function (xxx_done) in gcm.c is as follow: void complete(struct crypto_async_request *areq, int err) { if (!err) { err = async_next_step(); if (err == -EINPROGRESS || err == -EBUSY) return; }

Re: [PATCH v0 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-11-02 Thread hank peng
I have tested this patch on my MPC8548 machine box, kernel version is 2.6.30. There is a problem. #mdadm -C /dev/md0 -l5 -n3 /dev/sd{a,b,c} Recovery can be done successfully, interrupts looks normal. # cat /proc/interrupts CPU0 16: 16091057 OpenPIC Level mvSata 17: 0

Re: [PATCH] crypto: padlock-aes: Use the correct mask when checking whether copying is required

2009-11-02 Thread Chuck Ebbert
crypto: padlock-aes: Use the correct mask when checking whether copying is required Masking with PAGE_SIZE is just wrong... Signed-off-by: Chuck Ebbert --- vanilla-2.6.31.orig/drivers/crypto/padlock-aes.c +++ vanilla-2.6.31/drivers/crypto/padlock-aes.c @@ -236,7 +236,7 @@ static inline void ec

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-02 Thread Ingo Molnar
* Herbert Xu wrote: > On Mon, Nov 02, 2009 at 03:32:58PM +0100, Ingo Molnar wrote: > > > > Please use the standard construct and put an #ifndef __ASSEMBLY__ around > > it. > > You mean like this? > > diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h > index 0b20bbb..e22d

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-02 Thread Herbert Xu
On Mon, Nov 02, 2009 at 03:32:58PM +0100, Ingo Molnar wrote: > > Please use the standard construct and put an #ifndef __ASSEMBLY__ around > it. You mean like this? diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h index 0b20bbb..e22d237 100644 --- a/arch/x86/include/asm/i38

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-02 Thread Ingo Molnar
* Herbert Xu wrote: > On Mon, Nov 02, 2009 at 08:50:39AM +0100, Ingo Molnar wrote: > > > > A cleanup request: mind creating two macros for this PSHUFB MMX/SSE > > instruction in arch/x86/include/asm/i387.h, instead of open-coding the > > .byte sequences in ~6 places? > > I had a go at doing

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-02 Thread Herbert Xu
On Mon, Nov 02, 2009 at 08:50:39AM +0100, Ingo Molnar wrote: > > A cleanup request: mind creating two macros for this PSHUFB MMX/SSE > instruction in arch/x86/include/asm/i387.h, instead of open-coding the > .byte sequences in ~6 places? I had a go at doing that, but it seems that i387.h isn't

Re: [PATCH 2/2] crypto: pcrypt - Add pcrypt crypto parallelization wrapper

2009-11-02 Thread David Miller
From: Herbert Xu Date: Fri, 30 Oct 2009 09:30:55 -0400 > On Fri, Oct 30, 2009 at 02:27:34PM +0100, Steffen Klassert wrote: >> I'm going to send a workqueue based version of padata/pcrypt >> within the next week. > > Awesome! Thanks a lot for continuing this work Steffen. -- To unsubscribe from