Re: Crypto Fixes for 2.6.33

2010-02-01 Thread Herbert Xu
Hi Linus: This push fixes a couple of serious bugs: * UBIFS assertion failure caused by /dev/random (since forever) * Broken hmac support in padlock-sha (since 2.6.32) Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git or master.kernel.org:/pub/scm/linux/ke

Re: [PATCH 4/4] crypto: lmk2/lmk3 cipher block modes

2010-02-01 Thread Herbert Xu
On Mon, Feb 01, 2010 at 11:32:27AM +0100, Max Vozeler wrote: > > I'm wondering if I'm heading in the right direction since > this is stretching my understanding of the API: > > Would it look something like ccm, in that Not quite. > alloc does > - crypto_grab_skcipher(spawn, "cbc(aes)" > -

Re: [PATCH 4/4] crypto: lmk2/lmk3 cipher block modes

2010-02-01 Thread Max Vozeler
Hi Herbert, On Tue, Jan 19, 2010 at 09:00:38PM +1300, Herbert Xu wrote: > Let's keep lmk2/lmk3 as separate modes, but implement it as a > wrapper around cbc. That is, instead of allocating the cipher, > you'd allocate "cbc(cipher)" (as an ablkcipher) and use it to > perform the actual encryption/

[PATCH] crypto: pcrypt - call the complete function on error

2010-02-01 Thread Steffen Klassert
This fixes three forgotten calls to the complete function in the error case. Signed-off-by: Steffen Klassert --- crypto/pcrypt.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c index b9527d0..8020124 100644 --- a/crypto/pcrypt.c +++