Re: [PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

Obviously, this should have been named CRYPTO: Fix checkpatch errors & warnings in compress.c Should I re-send the patch or is it less noise & hassle if I just leave it this way? Richard On Wed, Feb 10, 2010 at 02:30, Richard Hartmann wrote: > > Signed-off-by: Richard Hartmann > --- >  crypt

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in aes_generic

Signed-off-by: Richard Hartmann --- crypto/aes_generic.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/aes_generic.c b/crypto/aes_generic.c index e78b7ee..a68c73d 100644 --- a/crypto/aes_generic.c +++ b/crypto/aes_generic.c @@ -1,4 +1,4 @@ -/* +/* * Crypto

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in fcrypt.c

Signed-off-by: Richard Hartmann --- crypto/fcrypt.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/fcrypt.c b/crypto/fcrypt.c index b82d61f..c33107e 100644 --- a/crypto/fcrypt.c +++ b/crypto/fcrypt.c @@ -60,13 +60,13 @@ do {

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in ecb.c

Signed-off-by: Richard Hartmann --- crypto/ecb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/ecb.c b/crypto/ecb.c index a46838e..935cfef 100644 --- a/crypto/ecb.c +++ b/crypto/ecb.c @@ -55,7 +55,7 @@ static int crypto_ecb_crypt(struct blkcipher_desc *desc,

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in des_generic.c

Signed-off-by: Richard Hartmann --- crypto/des_generic.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/crypto/des_generic.c b/crypto/des_generic.c index 5bd3ee3..249f903 100644 --- a/crypto/des_generic.c +++ b/crypto/des_generic.c @@ -869,8 +869,7 @@ static int des3_

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in deflate.c

Signed-off-by: Richard Hartmann --- crypto/deflate.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/crypto/deflate.c b/crypto/deflate.c index 9128da4..463dc85 100644 --- a/crypto/deflate.c +++ b/crypto/deflate.c @@ -1,14 +1,14 @@ -/* +/* * Crypto

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in crypto_null.c

Signed-off-by: Richard Hartmann --- crypto/crypto_null.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crypto/crypto_null.c b/crypto/crypto_null.c index cb71c91..07a8a96 100644 --- a/crypto/crypto_null.c +++ b/crypto/crypto_null.c @@ -1,11 +1,11 @@ -/* +/* *

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

Signed-off-by: Richard Hartmann --- crypto/cipher.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/cipher.c b/crypto/cipher.c index 9a1a731..39541e0 100644 --- a/crypto/cipher.c +++ b/crypto/cipher.c @@ -8,7 +8,7 @@ * * This program is free software; you can

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in crc32.c

Signed-off-by: Richard Hartmann --- crypto/crc32c.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/crc32c.c b/crypto/crc32c.c index 973bc2c..de9e55c 100644 --- a/crypto/crc32c.c +++ b/crypto/crc32c.c @@ -1,4 +1,4 @@ -/* +/* * Cryptographic API. * * CR

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cipher.c

Signed-off-by: Richard Hartmann --- crypto/compress.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/compress.c b/crypto/compress.c index 1ee3570..c33f076 100644 --- a/crypto/compress.c +++ b/crypto/compress.c @@ -7,7 +7,7 @@ * * This program is free softw

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cast6.c

Signed-off-by: Richard Hartmann --- crypto/cast6.c | 122 --- 1 files changed, 62 insertions(+), 60 deletions(-) diff --git a/crypto/cast6.c b/crypto/cast6.c index 007d02b..e0c15a6 100644 --- a/crypto/cast6.c +++ b/crypto/cast6.c @@ -11,7 +11

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in cast5.c

Signed-off-by: Richard Hartmann --- crypto/cast5.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crypto/cast5.c b/crypto/cast5.c index 8cbe28f..a1d2294 100644 --- a/crypto/cast5.c +++ b/crypto/cast5.c @@ -569,12 +569,12 @@ static const u32 sb8[256] = {

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in camellia.c

Signed-off-by: Richard Hartmann --- crypto/camellia.c | 616 ++-- 1 files changed, 308 insertions(+), 308 deletions(-) diff --git a/crypto/camellia.c b/crypto/camellia.c index 964635d..64cff46 100644 --- a/crypto/camellia.c +++ b/crypto/camellia.

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in authenc.c

Signed-off-by: Richard Hartmann --- crypto/authenc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/crypto/authenc.c b/crypto/authenc.c index 4d6f49a..1887090 100644 --- a/crypto/authenc.c +++ b/crypto/authenc.c @@ -194,7 +194,7 @@ static void authenc_verify_ah

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in arc4.c

From: Richard Hartmann Signed-off-by: Richard Hartmann --- crypto/arc4.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/crypto/arc4.c b/crypto/arc4.c index 8be47e1..8a61fa2 100644 --- a/crypto/arc4.c +++ b/crypto/arc4.c @@ -1,4 +1,4 @@ -/* +/* * Cryptograph

Re: [PATCH 1/1] SCRIPTS: Fix whitespace in get_maintainer output

On Wed, Feb 10, 2010 at 01:47, Joe Perches wrote: > One space not two after periods?  Horrors. Not quite, but still wrong and worthy of a fix :) For what it's worth, applying it would take less time than the sending and reading of these two emails ;) Still, any feedback is good feedback. Tha

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in api.c

Signed-off-by: Richard Hartmann --- crypto/api.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/crypto/api.c b/crypto/api.c index 798526d..033a714 100644 --- a/crypto/api.c +++ b/crypto/api.c @@ -10,7 +10,7 @@ * * This program is free software; you can r

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in anubis.c

Signed-off-by: Richard Hartmann --- crypto/anubis.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/crypto/anubis.c b/crypto/anubis.c index e42c3a8..77530d5 100644 --- a/crypto/anubis.c +++ b/crypto/anubis.c @@ -469,14 +469,13 @@ static int anubis_

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings in algapi.c

Signed-off-by: Richard Hartmann --- crypto/algapi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/algapi.c b/crypto/algapi.c index f149b1c..3e4524e 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -230,7 +230,7 @@ static struct crypto_larval *__crypto_re

[PATCH 1/1] CRYPTO: Fix checkpatch errors & warnings for blowfish

Signed-off-by: Richard Hartmann --- crypto/blowfish.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/crypto/blowfish.c b/crypto/blowfish.c index 6f5b487..a67d52e 100644 --- a/crypto/blowfish.c +++ b/crypto/blowfish.c @@ -1,4 +1,4 @@ -/* +/* * Cryptog

Re: [PATCH 1/1] SCRIPTS: Fix whitespace in get_maintainer output

On Wed, 2010-02-10 at 01:37 +0100, Richard Hartmann wrote: > - warn "$P: file '${file}' doesn't appear to be a patch. " > + warn "$P: file '${file}' doesn't appear to be a patch. " One space not two after periods? Horrors. Well if you like, but that's not what I like. Not-acked

[PATCH 1/1] CRYPTO: Fix checkpatch errors in aead.c

Signed-off-by: Richard Hartmann --- crypto/aead.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/aead.c b/crypto/aead.c index 0a55da7..6729e8f 100644 --- a/crypto/aead.c +++ b/crypto/aead.c @@ -1,13 +1,13 @@ /* * AEAD: Authenticated Encryption with Associat

[PATCH 3/3] SCRIPTS: Replace four whitespaces with tabs for indentation

Signed-off-by: Richard Hartmann --- scripts/checkpatch.pl | 172 1 files changed, 86 insertions(+), 86 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 96ca9f0..31f872f 100755 --- a/scripts/checkpatch.pl +++ b/script

[PATCH 2/3] SCRIPTS: s/should/must/ for all ERRORs

Signed-off-by: Richard Hartmann --- scripts/checkpatch.pl | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d5405aa..96ca9f0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl

[PATCH 1/3] SCRIPTS: Better error message for checkpath.pl

If the input file for checkpatch.pl is not a patch, print an error message that suggets -f. Signed-off-by: Richard Hartmann --- scripts/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3257d3d..d5405aa 100

[PATCH 1/1] SCRIPTS: Fix whitespace in get_maintainer output

Signed-off-by: Richard Hartmann --- scripts/get_maintainer.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 2f3230d..430928e 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -278,7 +2

[PATCH 1/1] CRYPTO: Fix checkpatch errors in ablkcipher.c

Signed-off-by: Richard Hartmann --- crypto/ablkcipher.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c index f6f0833..fe980da 100644 --- a/crypto/ablkcipher.c +++ b/crypto/ablkcipher.c @@ -1,6 +1,6 @@ /* * Asynchronous bloc

Re: [PATCH] dm-crypt: disable block encryption with arc4

On Tue, Feb 09, 2010 at 10:12:38PM +0100, Sebastian Andrzej Siewior wrote: > > >This is no different to any stream cipher. > Sure. So we fix arc4 and don't play mother . Okay I will into this :) That would be awesome. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>

Re: [PATCH] dm-crypt: disable block encryption with arc4

* Herbert Xu | 2010-02-10 07:45:19 [+1100]: >> Herbert, what happend to the "check for streamcipher" idea you had? Is >> it gone? On the other hand it wouldn't be probably that bad to have a > >Well again whether that should be done is up to the dm-crypt >maintainers. Milan liked that afaik. >> s

Re: [PATCH] dm-crypt: disable block encryption with arc4

On Tue, Feb 09, 2010 at 03:57:05PM +0100, Sebastian Andrzej Siewior wrote: > > >As to blacklisting algorithms not suitable for disk encryption, > >that is up to the dm-crypt maintainers to decide. > > Herbert, what happend to the "check for streamcipher" idea you had? Is > it gone? On the other ha

Re: [PATCH] dm-crypt: disable block encryption with arc4

On Tue, Feb 09, 2010 at 09:02:35AM -0500, Mikulas Patocka wrote: > > What is the fix for arc4? Copy the internal state after a key schedule and > restore it with every encryption? arc4 should be a blkcipher, not a cipher. Then it can have an IV which is where thie should be stored. > I think

Re: [TuxOnIce-devel] LZO irreversible output?

Hi. Nix wrote: > On 8 Feb 2010, Nigel Cunningham verbalised: >> That said, the actual code that TuxOnIce uses does already initialise >> the variable to PAGE_SIZE, so it seems that I might just have to run >> with the checking code enabled (with this fix) for a while, until the >> issue is found.

Re: [TuxOnIce-devel] LZO irreversible output?

On 8 Feb 2010, Nigel Cunningham verbalised: > That said, the actual code that TuxOnIce uses does already initialise > the variable to PAGE_SIZE, so it seems that I might just have to run > with the checking code enabled (with this fix) for a while, until the > issue is found. If you push the fix s

Re: [PATCH] dm-crypt: disable block encryption with arc4

* Herbert Xu | 2010-02-09 18:37:18 [+1100]: >Mikulas Patocka wrote: >> >> You should rather add a flag CRYPTO_ALG_CHANGES_STATE to determine that a >> cipher can't be used to encrypt disks. > >No, please see my reply in the previous thread. What we should >do is fix arc4. I just haven't got a

Re: [PATCH] dm-crypt: disable block encryption with arc4

On Tue, 9 Feb 2010, Herbert Xu wrote: > Mikulas Patocka wrote: > > > > You should rather add a flag CRYPTO_ALG_CHANGES_STATE to determine that a > > cipher can't be used to encrypt disks. > > No, please see my reply in the previous thread. What we should > do is fix arc4. I just haven't got

Re: crypto_shash_update & CRYPTO_TFM_REQ_MAY_SLEEP

On Tue, Feb 09, 2010 at 10:45:31AM +0200, Dmitry Kasatkin wrote: > Hi, > > Ok... > > But normally kernel client code uses sync API as shash. > > And I provide async hw driver via async ahash API. > That is simply will not be used at all. > > Client must be changed to use async ahash API in orde

Re: crypto_shash_update & CRYPTO_TFM_REQ_MAY_SLEEP

Hi, Ok... But normally kernel client code uses sync API as shash. And I provide async hw driver via async ahash API. That is simply will not be used at all. Client must be changed to use async ahash API in order to benefit from HW crypto. Right? Thanks, Dmitry ext Herbert Xu wrote: > Dmitry