Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-22 Thread Mikulas Patocka
On Tue, 16 Feb 2010, Herbert Xu wrote: On Fri, Feb 12, 2010 at 09:42:28AM +0100, Sebastian Andrzej Siewior wrote: -static void arc4_crypt(struct crypto_tfm *tfm, u8 *out, const u8 *in) +static void arc4_ivsetup(struct arc4_ctx *ctx, u8 *iv) { - struct arc4_ctx *ctx =

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-22 Thread Sebastian Andrzej Siewior
* Herbert Xu | 2010-02-22 08:52:17 [+0800]: On Mon, Feb 22, 2010 at 08:45:47AM +0800, Herbert Xu wrote: How about this? You extend the IV by one more byte, and use that byte as a boolean flag to indicate whether the IV is valid. All So I trick the crypto api to allocate more bytes than

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-22 Thread Herbert Xu
On Mon, Feb 22, 2010 at 02:40:49PM -0500, Mikulas Patocka wrote: So what we could do is simply add a new blkcipher arc4, alongside the existing cipher arc4. Then we can convert the existing users across, and finally remove the old arc4. arc4 can't be used as a block cipher --- see this

Re: [PATCH] crypto/arc4: convert this stream cipher into a block cipher

2010-02-22 Thread Herbert Xu
On Mon, Feb 22, 2010 at 11:08:35PM +0100, Sebastian Andrzej Siewior wrote: * Herbert Xu | 2010-02-22 08:52:17 [+0800]: On Mon, Feb 22, 2010 at 08:45:47AM +0800, Herbert Xu wrote: How about this? You extend the IV by one more byte, and use that byte as a boolean flag to indicate whether

[PATCH 1/2] crypto: authenc - Use correct ahash complete functions

2010-02-22 Thread Steffen Klassert
We accidentally assigned the ahash update complete function to the wrong function pointer in crypto_authenc_verify. This patch fixes this. Signed-off-by: Steffen Klassert steffen.klass...@secunet.com --- crypto/authenc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 2/2] crypto: authenc - move saved IV in front of the ablkcipher request

2010-02-22 Thread Steffen Klassert
In crypto_authenc_encrypt() we save the IV behind the ablkcipher request. To save space on the request, we overwrite the ablkcipher request with a ahash request after encryption. So the IV may be overwritten by the ahash request. This patch fixes this by placing the IV in front of the