On Tue, Jul 06, 2010 at 11:36:37AM -0700, Justin P. Mattock
(justinmatt...@gmail.com) wrote:
> The below patch gets rid of an unused variable ctx reported by
> GCC when building the kernel.
> CC [M] drivers/crypto/hifn_795x.o
> drivers/crypto/hifn_795x.c: In function 'hifn_flush':
> drivers/cry
On 07/06/2010 11:58 AM, Evgeniy Polyakov wrote:
On Tue, Jul 06, 2010 at 11:36:37AM -0700, Justin P. Mattock
(justinmatt...@gmail.com) wrote:
The below patch gets rid of an unused variable ctx reported by
GCC when building the kernel.
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795
The below patch gets rid of an unused variable ctx reported by
GCC when building the kernel.
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795x.c: In function 'hifn_flush':
drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
drivers/crypto/hifn_795x.c: In functio
On Tue, 6 Jul 2010 09:59:38 -0700
"Justin P. Mattock" wrote:
> @@ -2035,7 +2034,7 @@ static void hifn_flush(struct hifn_device *dev)
>
> spin_lock_irqsave(&dev->lock, flags);
> while ((async_req = crypto_dequeue_request(&dev->queue))) {
> - ctx = crypto_tfm_ctx(async_req
This certainly does not look right! Returning with IRQs disabled
is considered to be rude.
I believe the right answer is to delete the line initialising ctx.
Thanks,
o.k. hopefully this is correct this time, resent with the following
change. let me know if it's legit or not..
Justin P. Ma
This is version two of fixing a warning message from GCC
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795x.c: In function 'hifn_flush':
drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
drivers/crypto/hifn_795x.c: In function 'hifn_process_queue':
drivers/cryp
On 07/06/2010 12:03 AM, Herbert Xu wrote:
Justin P. Mattock wrote:
The below fixes a warning message generated by GCC
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795x.c: In function 'hifn_flush':
drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
drivers/c
Justin P. Mattock wrote:
> The below fixes a warning message generated by GCC
> CC [M] drivers/crypto/hifn_795x.o
> drivers/crypto/hifn_795x.c: In function 'hifn_flush':
> drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
> drivers/crypto/hifn_795x.c: In function 'hifn