Re: [PATCH] Adding ADMA support for PPC460EX DMA engine.

2010-07-23 Thread Stefan Roese
Hi Marri, On Friday 23 July 2010 02:57:18 tma...@amcc.com wrote: From: Tirumala Marri tma...@amcc.com This patch will add ADMA support for DMA engine and HW offload for XOR/ADG (RAID-5/6) functionalities. 1. It supports memcpy, xor, GF(2) based RAID-6. 2. It supports interrupt

Re: Crypto Fixes for 2.6.35

2010-07-23 Thread Lee Nipper
On Fri, Jul 23, 2010 at 02:27, Herbert Xu herb...@gondor.apana.org.au wrote: If it causes a crash or has other serious implications then I will push it.  However, if it simply results in a broken hash computation, a failure that should be fairly obvious, then it can wait til the next cycle.

Re: [PATCH] Adding ADMA support for PPC460EX DMA engine.

2010-07-23 Thread Dan Williams
On Thu, Jul 22, 2010 at 11:15 PM, Stefan Roese s...@denx.de wrote: Hi Marri, On Friday 23 July 2010 02:57:18 tma...@amcc.com wrote: From: Tirumala Marri tma...@amcc.com   This patch will add ADMA support for DMA engine and HW offload for   XOR/ADG (RAID-5/6) functionalities.   1. It

RE: [PATCH] Adding ADMA support for PPC460EX DMA engine.

2010-07-23 Thread Tirumala Marri
As you describe above, a lot of the code seems to be copied from drivers/dma/ppc4xx/adma.c/h. Wouldn't it make more sense to factor out the common code instead of duplicating it? Hi Stefan, Thanks for the review. There are definitely some functions can be moved to a common file. Hi