Re: [PATCH 0/5] RFC v2: AF_ALG auditing

2010-12-01 Thread Herbert Xu
On Wed, Nov 24, 2010 at 06:05:50PM +0100, Miloslav Trmač wrote: > > Miloslav Trmač (5): > Add general crypto auditing infrastructure > Add unique IDs to AF_ALG sockets > Add "alg_name" operation to af_alg_type. > Audit type-independent events > Audit type-specific crypto operations Acke

Re: [RFC] [PATCH 06/11] esp4: Add support for IPsec extended sequence numbers

2010-12-01 Thread Herbert Xu
On Mon, Nov 22, 2010 at 11:30:14AM +0100, Steffen Klassert wrote: > > @@ -205,11 +228,18 @@ static int esp_output(struct xfrm_state *x, struct > sk_buff *skb) > skb_to_sgvec(skb, sg, >esph->enc_data + crypto_aead_ivsize(aead) - skb->data, >clen + alen)

Re: [RFC] [PATCH 02/11] crypto: Use scatterwalk_crypto_chain

2010-12-01 Thread Herbert Xu
On Mon, Nov 22, 2010 at 11:26:54AM +0100, Steffen Klassert wrote: > Use scatterwalk_crypto_chain in favor of locally defined chaining functions. > > Signed-off-by: Steffen Klassert I've applied patches 1&2 since they're logically separate from the rest of the series and make sense on their own.

Re: [PATCH] crypto: padlock: fix for non-64byte aligned data

2010-12-01 Thread Herbert Xu
On Fri, Nov 05, 2010 at 03:12:38PM +0100, Phil Sutter wrote: > > Yes, kind of. With that trivial fix applied, the driver is stable most > of the time. Great. > Yes, it does, but triggering the bug is not really trivial. I've had > best results with a speed testing tool using the asynchronous int

Re: [PATCH v1.5 4/5] keys: add new trusted key-type

2010-12-01 Thread David Safford
On Wed, 2010-12-01 at 17:48 +, David Howells wrote: > Mimi Zohar wrote: > > > +static int TSS_sha1(const unsigned char *data, const unsigned int datalen, > > + unsigned char *digest) > > You seem to have made a bunch of integer length parameters 'const'. Why? I > was suggesti

Re: [PATCH v1.5 4/5] keys: add new trusted key-type

2010-12-01 Thread David Howells
Mimi Zohar wrote: > +static int TSS_sha1(const unsigned char *data, const unsigned int datalen, > + unsigned char *digest) You seem to have made a bunch of integer length parameters 'const'. Why? I was suggesting making them size_t, not const. I was suggesting making the data