Hello Herbert,
On Thu, Jan 06, 2011 at 05:12:41PM +1100, Herbert Xu wrote:
> On Wed, Jan 05, 2011 at 02:16:22PM +0100, Mario 'BitKoenig' Holbe wrote:
> > attached. I hope I got the gcc call right. However, I prefer the objdump
> > output anyways, so this one is attached as well.
> I see what you m
On Thu, Jan 06, 2011 at 02:15:16PM +0100, Mario 'BitKoenig' Holbe wrote:
>
> The patch helps. No crashes, meaningful random data - perfect.
> I still have 2 small annotations...
Thanks for testing!
> 1. Having ECX on the clobber-list is not really necessary.
> XSTORE doesn't touch ECX at all.
> R
On 01/06/2011 07:35 AM, Herbert Xu wrote:
> On Thu, Jan 06, 2011 at 02:15:16PM +0100, Mario 'BitKoenig' Holbe wrote:
>>
>> The patch helps. No crashes, meaningful random data - perfect.
>> I still have 2 small annotations...
>
> Thanks for testing!
>
>> 1. Having ECX on the clobber-list is not re
On Fri, Jan 07, 2011 at 12:35:41AM +1100, Herbert Xu wrote:
> On Thu, Jan 06, 2011 at 02:15:16PM +0100, Mario 'BitKoenig' Holbe wrote:
> > 1. Having ECX on the clobber-list is not really necessary.
> > XSTORE doesn't touch ECX at all.
> > REP XSTORE would touch it, but for this ECX would be an inpu
On Wed, Jan 5, 2011 at 4:01 PM, Herbert Xu wrote:
>
> * Crypto API interface for user-space (hash + skcipher)
Is there really any point to this? And can we get more explanation of
what the interface is, and who would use it?
If you need crypto in user space, it's almost invariably better done
in
On Thu, Jan 06, 2011 at 10:05:46AM -0800, Linus Torvalds wrote:
>
> Is there really any point to this? And can we get more explanation of
> what the interface is, and who would use it?
I think you've answered it yourself in the third paragraph :)
> If you need crypto in user space, it's almost in
On Thu, Jan 6, 2011 at 1:16 PM, Herbert Xu wrote:
> On Thu, Jan 06, 2011 at 10:05:46AM -0800, Linus Torvalds wrote:
>>
>> Is there really any point to this? And can we get more explanation of
>> what the interface is, and who would use it?
>
> I think you've answered it yourself in the third parag
On Thu, Jan 06, 2011 at 01:23:19PM -0800, Linus Torvalds wrote:
>
> Explanations of interface. Code. Who uses it? What are the actual
> performance benefits on real code?
You snipped out the bit in my reply where I expanded on it:
: Right. This purpose of this interface is to access the async
:
On Thu, Jan 06, 2011 at 04:46:02PM -0500, Pavel Roskin wrote:
>
> Are there any chances AEAD will be supported? Is the API extendable to
> allow that?
Yes we can support AEAD. However, as there weren't any existing
user-space users that could benefit immediately, I have not added
it at this po
On 01/06/2011 04:16 PM, Herbert Xu wrote:
This is also why only hash and skcipher are supported as they
are the main algorithm types supported by teh current async
drivers in the kernel.
Are there any chances AEAD will be supported? Is the API extendable to
allow that?
If I remember correc
On Thu, Jan 6, 2011 at 1:39 PM, Herbert Xu wrote:
> On Thu, Jan 06, 2011 at 01:23:19PM -0800, Linus Torvalds wrote:
>>
>> Explanations of interface. Code. Who uses it? What are the actual
>> performance benefits on real code?
>
> You snipped out the bit in my reply where I expanded on it:
You did
On Thu, Jan 06, 2011 at 02:13:17PM -0800, Linus Torvalds wrote:
>
> But I'm still missing the part where you show that there is any actual
> use case that makes sense, and that actually improves performance.
> Maybe it's been posted somewhere else, but the thing is, you're asking
> _me_ to pull, a
From: Herbert Xu
Date: Fri, 7 Jan 2011 09:30:42 +1100
> On Thu, Jan 06, 2011 at 02:13:17PM -0800, Linus Torvalds wrote:
>>
>> But I'm still missing the part where you show that there is any actual
>> use case that makes sense, and that actually improves performance.
>> Maybe it's been posted som
On Thu, Jan 06, 2011 at 02:43:35PM -0800, Linus Torvalds wrote:
>
> Can you do the "bypass directly to the TCP stream" with the interface
> you added? It isn't at all obvious how it would work.
Yes it can. The interface allows zero-copy in both directions
using the splice interface. Here is a sa
On Thursday 06 January 2011 23:46:02 Pavel Roskin wrote:
> On 01/06/2011 04:16 PM, Herbert Xu wrote:
> > This is also why only hash and skcipher are supported as they
> > are the main algorithm types supported by teh current async
> > drivers in the kernel.
>
> Are there any chances AEAD will be s
On Thu, Jan 6, 2011 at 2:30 PM, Herbert Xu wrote:
>
> The main use-case is bulk encryption/hashing in user-space. For
> example, on Sparc Niagara2 you need to use SPU (Stream Processing
> Unit) in order to do crypto at 10Gb/s over the network.
Umm. But doesn't that require that the data then be
On Thu, Jan 6, 2011 at 2:53 PM, Herbert Xu wrote:
> On Thu, Jan 06, 2011 at 02:43:35PM -0800, Linus Torvalds wrote:
>>
>> Can you do the "bypass directly to the TCP stream" with the interface
>> you added? It isn't at all obvious how it would work.
>
> Yes it can. The interface allows zero-copy i
On Thu, Jan 06, 2011 at 03:25:32PM -0800, Linus Torvalds wrote:
>
> Ok. So can we actually get numbers for this?
As you alluded to, we need real non-x86 hardware to get some
proper numbers. Unfortunately I'm currently a continent away
from my async hardware so all I can give you are software
numb
Quoting Herbert Xu :
setsockopt(tfmfd, SOL_ALG, ALG_SET_KEY,
"\x06\xa9\x21\x40\x36\xb8\xa1\x5b"
"\x51\x2e\x03\xd5\x34\x12\x00\x06", 16);
By the way, is it a good idea to use setsockopt() this way? Some keys
may be large. And if AEAD is supporte
From: Herbert Xu
Date: Fri, 7 Jan 2011 11:14:59 +1100
> Anyway, here is a test program that does a set number (1024 * 1024)
> of 4096-byte (total 4GB) encryptions with libssl and kernel crypto.
> The result on my Core 2 (in a KVM VM FWIW) is:
>
> lenny0:~# time ./test_crypto > /dev/null
>
> re
On Thu, Jan 06, 2011 at 09:39:28PM -0500, Pavel Roskin wrote:
>
> By the way, is it a good idea to use setsockopt() this way? Some keys
> may be large. And if AEAD is supported, will it use setsockopt() for
> the unencrypted authenticated data?
For large keys (i.e., asymmetric key crypto) th
On Thu, Jan 06, 2011 at 06:43:02PM -0800, David Miller wrote:
>
> da...@maramba:~$ time ./crypto_user_test >/dev/null
>
> real 0m46.586s
> user 0m3.280s
> sys0m43.230s
> da...@maramba:~$ time ./crypto_user_test software >/dev/null
>
> real 10m40.336s
> us
On Thu, Jan 06, 2011 at 03:42:55PM +0100, Mario 'BitKoenig' Holbe wrote:
>
> ho...@ideapad ~ % gcc -o via-rng-test via-rng-test.c
> ho...@ideapad ~ % ./via-rng-test
> 0xbff09d40:
> ecx: aa55aa55 edx: ff03 edi: 0xbff09d40
> ecx: aa55aa55 edx: 0003 edi: 0xbff09d48
> 0xbff09d4
On Fri, Jan 07, 2011 at 02:49:48PM +1100, Herbert Xu wrote:
>
> commit 0735ac1f2551d9f9d356126aaf3b1110150918e6
> Author: Herbert Xu
> Date: Fri Jan 7 14:48:57 2011 +1100
Here are the other patches to fix this problem:
commit 21493088733e6e09dac6f54595a1b6b8ab1e68fd
Author: Herbert Xu
Date:
commit 55db8387a5e8d07407f0b7c6b2526417a2bc6243
Author: Herbert Xu
Date: Fri Jan 7 14:55:06 2011 +1100
hwrng: via_rng - Fix memory scribbling on some CPUs
It has been reported that on at least one Nano CPU the xstore
instruction will write as many as 16 bytes of data to the out
25 matches
Mail list logo
