[PATCH 00/11] crypto: omap-sham driver fixes

Hi, Recently we got crashes few times after some other patches to 2.6.32 kernel. This patch set greatly prevents race condition situations. No crashes are noticed any more. Now the driver should be ok for multi core as well. Regards, Dmitry Dmitry Kasatkin (11): omap-sham: remove extra

[PATCH 01/11] omap-sham: remove extra reference

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Request pointer is already available in the function. Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/omap-sham.c

[PATCH 04/11] omap-sham: replace flags operation with atomic bit operations

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Some flags are changed in interrupt handlers and verified in the tasklet. There might be a race condition when tasklet is interrupted or another cpu/core will run IRQ handler and tasklet in parallel. Atomic bitops functions are now used instead of

[PATCH 03/11] omap-sham: replace flags bit mask with bit number

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Flags mask cannot be used with atomic bit operations. This patch changes masks to bit numbers. Atomic bit operations will be used by following patches. Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c | 102

[PATCH 06/11] omap-sham: remove unnecessary local variable

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index b959dc6..84e5890 100644

[PATCH 08/11] omap-sham: irq and dma handling changes

From: Dmitry Kasatkin dmitry.kasat...@nokia.com It could be a situation, that tasklet is executed twice because of certain delay between dma callback and irq handler execution. In that case, second tasklet execution could actually corrupt the data of the new started dma transactions. This patch

[PATCH 07/11] omap-sham: remove dedicated queue handling tasklet

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Calling omap_sham_handle_queue from done tasklet should be done after irq scheduled tasklet completes. Having additional tasklet does not solve that issue because it might be execute before. So queue handling tasklet has been removed and

[PATCH 10/11] omap-sham: clear device flags when finishing request

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 7ca7075..804c16b

[PATCH 11/11] omap-sham: do not schedule tasklet if there is no active requests

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 804c16b..6399a8f

[PATCH 09/11] omap-sham: irq handler must not clear error code

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index a8de7b8..7ca7075 100644

[PATCH 05/11] omap-sham: move some flags to device context

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Couple of context flags have been moved to device flags. IRQ and tasklet handlers does not need to access request context anymore. Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c | 19 ++-

[PATCH 02/11] omap-sham: remove unused code

From: Dmitry Kasatkin dmitry.kasat...@nokia.com Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com --- drivers/crypto/omap-sham.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 8a45fb7..ac12a60