Re: [RFC v1.1 3/5] evm: digital signature support

2011-08-15 Thread James Morris
On Thu, 11 Aug 2011, Dmitry Kasatkin wrote: > From: Dmitry Kasatkin > > When building an image, which has to be flashed to different devices, > an HMAC cannot be used to sign file metadata, as the HMAC key is different > on every device. File metadata can be protected using digital signature. >

Re: [RFC v1.1 2/5] crypto: ksign - digital signature verification support

2011-08-15 Thread James Morris
On Thu, 11 Aug 2011, Dmitry Kasatkin wrote: > +static int ksign_verify_rsa(struct key *key, > + const char *sig, int siglen, > +const char *h, int hlen) > +{ > + int err = -ENOMEM; > + unsigned long len; > + unsigned long mlen, mblen; > + unsigne

Re: [RFC v1.1 1/5] crypto: GnuPG based MPI lib

2011-08-15 Thread James Morris
On Thu, 11 Aug 2011, Dmitry Kasatkin wrote: > From: Dmitry Kasatkin > > Adds the multi-precision-integer maths library which was originally taken > from GnuPG and ported to the kernel by (among others) David Howells. > This version is taken from Fedora kernel 2.6.32-71.14.1.el6. First thing --

Re: [RFC v1.1 1/5] crypto: GnuPG based MPI lib

2011-08-15 Thread Dmitry Kasatkin
Hi, Can anyone please tell why this patch did not appear in archives? I have received it in my 2 accounts, but I cannot see it in archive. Is any size limitations?? - Dmitry On 11/08/11 20:20, Dmitry Kasatkin wrote: > From: Dmitry Kasatkin > > Adds the multi-precision-integer maths library whi

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-15 Thread Josh Boyer
On Mon, Aug 15, 2011 at 03:15:28PM +0800, Herbert Xu wrote: > On Thu, Aug 11, 2011 at 12:40:41PM -0400, Josh Boyer wrote: > > The ablkcipher structure in ablk_ecb_alg is lacking an ivsize setting. > > This causes the algorithm to fail it's self-test when it's registered > > with the error message:

Re: [PATCH 01/16] crypto: authenc - Don't multiply priorities

2011-08-15 Thread Steffen Klassert
On Mon, Aug 15, 2011 at 04:55:46PM +0800, Herbert Xu wrote: > On Mon, Aug 15, 2011 at 10:02:57AM +0200, Steffen Klassert wrote: > > > > I don't think it is broken. It's just easier to handle if an underlying > > algorithm changes it's priority. If the user changes the priority of a > > certain algo

Re: [PATCH 01/16] crypto: authenc - Don't multiply priorities

2011-08-15 Thread Herbert Xu
On Mon, Aug 15, 2011 at 10:02:57AM +0200, Steffen Klassert wrote: > > I don't think it is broken. It's just easier to handle if an underlying > algorithm changes it's priority. If the user changes the priority of a > certain algorithm, I take the difference of the old and new priority > value and a

Re: [PATCH 01/16] crypto: authenc - Don't multiply priorities

2011-08-15 Thread Steffen Klassert
On Mon, Aug 15, 2011 at 03:19:29PM +0800, Herbert Xu wrote: > > Actually the reason it places a bigger weight on the cipher's > priority is because typically ciphers are slower than hashes. > So this is expressing the fact that we'd rather use a faster > cipher with a slower hash than the other wa

Re: [PATCH] n2_crypto: Fix a get/put_cpu() imbalance

2011-08-15 Thread Herbert Xu
On Sat, Aug 13, 2011 at 09:59:58AM +0200, Thomas Meyer wrote: > From: Thomas Meyer > > Fix a get/put_cpu() imbalance in the error case when qp == NULL > > Signed-off-by: Thomas Meyer Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://

Re: [PATCH 01/16] crypto: authenc - Don't multiply priorities

2011-08-15 Thread Herbert Xu
On Thu, Aug 11, 2011 at 01:26:39PM +0200, Steffen Klassert wrote: > Most crypto algorithms simply take the priority value of the underlying > algorithm and add some value to calculate the algorithms priority. > The only exeptions are the authenc algorithms. We change the authenc > algorithms to cal

Re: [PATCH] crypto: aesni-intel - Add ivsize to ablk_ecb_alg

2011-08-15 Thread Herbert Xu
On Thu, Aug 11, 2011 at 12:40:41PM -0400, Josh Boyer wrote: > The ablkcipher structure in ablk_ecb_alg is lacking an ivsize setting. > This causes the algorithm to fail it's self-test when it's registered > with the error message: > > [0.806920] alg: skcipher: Failed to load transform for ecb-