Re: [PATCH 2/2] crypto: serpent - rename serpent.c to serpent_generic.c

2011-11-30 Thread Herbert Xu
On Wed, Nov 23, 2011 at 12:21:06PM +0200, Jussi Kivilinna wrote: Now that serpent.c has been cleaned from checkpatch warnings, we can do clean rename. Signed-off-by: Jussi Kivilinna jussi.kivili...@mbnet.fi Both patches applied. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home

Re: [PATCH] crypto: serpent-sse2 - should select CRYPTO_CRYPTD

2011-11-30 Thread Herbert Xu
On Thu, Nov 24, 2011 at 10:35:29AM -0800, Randy Dunlap wrote: On 11/23/2011 10:37 PM, Jussi Kivilinna wrote: Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD. Reported-by: Randy Dunlap rdun...@xenotime.net

Re: [PATCH 02/16] MPILIB: Add a missing ENOMEM check [ver #2]

2011-11-30 Thread Serge Hallyn
On 11/29/2011 05:43 PM, David Howells wrote: Add a missing ENOMEM check. Signed-off-by: David Howellsdhowe...@redhat.com --- lib/mpi/mpicoder.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c index fe84bb9..6e225a8 100644

Re: [PATCH 02/16] MPILIB: Add a missing ENOMEM check [ver #2]

2011-11-30 Thread David Howells
Serge Hallyn serge.hal...@canonical.com wrote: p = buffer = kmalloc(n, GFP_KERNEL); + if (p 0) + return NULL; Sorry, maybe i'm having a confused morning, but shouldn't this check be for p==NULL rather than p0? Bah. You are, of course, right. Updated for the next

Re: [RFC][PATCH 00/16] Crypto keys and module signing [ver #2]

2011-11-30 Thread Greg KH
On Tue, Nov 29, 2011 at 11:42:58PM +, David Howells wrote: Here are a set of patches that create a framework for using cryptographic keys within the kernel. The patches can also be found at:

Re: [PATCH v5.1 00/14] crc32c: Add faster algorithm and self-test code

2011-11-30 Thread Andrew Morton
On Mon, 28 Nov 2011 14:36:59 -0800 Darrick J. Wong djw...@us.ibm.com wrote: This patchset (re)uses Bob Pearson's crc32 slice-by-8 code to stamp out a software crc32c implementation. I think the attributions here are all messed up. As the patches stand, it appears that you wrote all of them.