Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

2012-02-02 Thread Steffen Klassert
On Thu, Feb 02, 2012 at 03:42:43PM +0100, Jesper Juhl wrote: > On Thu, 2 Feb 2012, Steffen Klassert wrote: > > > > Your first patch is correct. > > > Thank you for the explanation. > > Can I take that to mean that I can add your Acked-by: if/when I resend the > patch? > Sure, Acked-by: Steff

Re: [PATCH 4/3] sha512: reduce stack usage even on i386

2012-02-02 Thread Herbert Xu
On Mon, Jan 30, 2012 at 01:10:48PM +0200, Alexey Dobriyan wrote: > > For some reason it doesn't. :-( I've also tried full barriers. OK, I don't think it worked in the sha1 case either, as on my i386 here lib/sha1.c ends up using nearly 500 bytes of stack space. It appears that the crux of the is

Re: [PATCH] In crypto_add_alg(), 'exact' wants to be initialized to 0

2012-02-02 Thread Jesper Juhl
On Thu, 2 Feb 2012, Steffen Klassert wrote: > On Wed, Feb 01, 2012 at 09:21:39PM +0100, Jesper Juhl wrote: > > On Wed, 1 Feb 2012, devendra.aaru wrote: > > > > > On Sun, Jan 29, 2012 at 5:39 PM, Jesper Juhl wrote: > > > > We declare 'exact' without initializing it and then do: > > > > > > > > [.