Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Linus Walleij
On Thu, Apr 25, 2013 at 4:11 PM, Arnd Bergmann wrote: > The dma engine driver must know the address in its dma space, while the > slave driver has it available in physical space. These two are often the > same, but there is no generic way to convert between the two, especially > if the dma engine

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Vinod Koul
On Fri, Apr 26, 2013 at 10:28:39AM +0200, Linus Walleij wrote: > On Thu, Apr 25, 2013 at 4:11 PM, Arnd Bergmann wrote: > > > The dma engine driver must know the address in its dma space, while the > > slave driver has it available in physical space. These two are often the > > same, but there is

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Linus Walleij
On Fri, Apr 26, 2013 at 10:16 AM, Vinod Koul wrote: >> OK I could cook a patch for that, but I think I need some input from >> Vinod and/or Russell on this. > the dma_slave_config is physical address that should be passed directly to the > controller. Obviosuly it should phys_addr_t :) OK! Sent

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Arnd Bergmann
On Friday 26 April 2013 10:28:39 Linus Walleij wrote: > > However this rings a bell that there may be a possible relation to > DMA-API, since that API syncs memory buffers to the DMA > address space if there is some MMU inbetween the DMA and the > (ordinary, non-device) memory. > > So if we think

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Arnd Bergmann
On Friday 26 April 2013 13:46:46 Vinod Koul wrote: > > The mapping & unmapping of dma buffer (memcpy and memory buffer in this txn) > is > required to be performed by the client driver. The dmanegine or dmaengine > driver > will not do that for you... I've been wondering about this part: since

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Russell King - ARM Linux
On Fri, Apr 26, 2013 at 01:46:46PM +0530, Vinod Koul wrote: > On Fri, Apr 26, 2013 at 10:28:39AM +0200, Linus Walleij wrote: > > On Thu, Apr 25, 2013 at 4:11 PM, Arnd Bergmann wrote: > > > > > The dma engine driver must know the address in its dma space, while the > > > slave driver has it availa

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-26 Thread Russell King - ARM Linux
On Fri, Apr 26, 2013 at 11:39:20AM +0200, Arnd Bergmann wrote: > On Friday 26 April 2013 13:46:46 Vinod Koul wrote: > > > > The mapping & unmapping of dma buffer (memcpy and memory buffer in this > > txn) is > > required to be performed by the client driver. The dmanegine or dmaengine > > driver

[PATCH] crypto: caam - FIX RNG init for RNG greater than equal to 4

2013-04-26 Thread Ruchika Gupta
For SEC including a RNG block version >= 4, special initialization must occur before any descriptor that uses RNG block can be submitted. This initialization is required not only for SEC with version greater than 5.0, but for SEC with RNG version >=4. There may be a case where RNG has already been

RE: [PATCH] crypto: caam - FIX RNG init for RNG greater than equal to 4

2013-04-26 Thread Garg Vakul-B16394
Reviewed-by: Vakul Garg > -Original Message- > From: Gupta Ruchika-R66431 > Sent: Friday, April 26, 2013 3:45 PM > To: linux-crypto@vger.kernel.org > Cc: Herbert Xu; David S. Miller; Phillips Kim-R1AAHA; Gupta Ruchika- > R66431; Porosanu Alexandru-B06830; Greg Kroah-Hartman; Garg Vakul-B1

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-26 Thread Herbert Xu
On Thu, Apr 25, 2013 at 10:28:30AM -0700, Tim Chen wrote: > > @@ -51,6 +54,98 @@ static const __u16 t10_dif_crc_table[256] = { > 0xF0D8, 0x7B6F, 0x6C01, 0xE7B6, 0x42DD, 0xC96A, 0xDE04, 0x55B3 > }; > > +#ifdef CONFIG_CRYPTO_CRCT10DIF No need for ifdefs, just make it unconditional like the

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-26 Thread Tim Chen
On Fri, 2013-04-26 at 20:52 +0800, Herbert Xu wrote: > On Thu, Apr 25, 2013 at 10:28:30AM -0700, Tim Chen wrote: > > > > @@ -51,6 +54,98 @@ static const __u16 t10_dif_crc_table[256] = { > > 0xF0D8, 0x7B6F, 0x6C01, 0xE7B6, 0x42DD, 0xC96A, 0xDE04, 0x55B3 > > }; > > > > +#ifdef CONFIG_CRYPTO_CR

Re: [PATCH 1/2] lib: Add lz4 compressor module

2013-04-26 Thread Andrew Morton
On Fri, 26 Apr 2013 15:51:05 +1000 Stephen Rothwell wrote: > Hi, > > On Fri, 26 Apr 2013 14:02:01 +0900 "Chanho Min" wrote: > > > > > > @@ -0,0 +1,23 @@ > > +#include > > + > > +int __attribute__((weak)) __clzsi2(int val) > > We have __weak in And lib/clz.c needs a few more includes, for