[PATCH] drivers/crypto:caam:Map src buffer before access in CAAM driver

2013-09-11 Thread Yashpal.Dutta
From: Yashpal Dutta yashpal.du...@freescale.com KMap the buffers before copying trailing bytes during hmac in CAAM driver into a session temporary buffer. This is required if pinned buffer from user-space is send to CAAM driver during hmac and is safe even if hmac request is generated from within

Re: [PATCH] crypto_memcmp: add constant-time memcmp

2013-09-11 Thread Marcelo Cerri
The discussion that Daniel pointed out has another interesting point regarding the function name. I don't think it's a good idea to name it crypto_memcpy since it doesn't have behavior the same way as strcmp. Florian suggested in the thread names such crypto_mem_equal, which I think fits better

Re: [PATCH] drivers/crypto:caam:Map src buffer before access in CAAM driver

2013-09-11 Thread Horia Geantă
On 9/11/2013 9:02 AM, yashpal.du...@freescale.com wrote: From: Yashpal Dutta yashpal.du...@freescale.com KMap the buffers before copying trailing bytes during hmac in CAAM driver into a session temporary buffer. This is required if pinned buffer from user-space is send to CAAM driver during

Re: [PATCH] crypto_memcmp: add constant-time memcmp

2013-09-11 Thread James Yonan
On 10/09/2013 12:57, Daniel Borkmann wrote: There was a similar patch posted some time ago [1] on lkml, where Florian (CC) made a good point in [2] that future compiler optimizations could short circuit on this. This issue should probably be addressed in such a patch here as well. [1]

question about rfc404 support.

2013-09-11 Thread Hsieh, Che-Min
Herbert: Can you confirm the following. Thanks. Rfc2404 - The Use of HMAC-SHA-1-96 within ESP and AH For the support, I can't find any algorithm to be specified in the .craname of ahash_alg for Rfc2404. From http://www.freebsd.org/cgi/man.cgi?query=setkeysektion=8 it says the

Re: [3.12-rc1] Dependency on module-init-tools = 3.11 ?

2013-09-11 Thread Herbert Xu
On Thu, Sep 12, 2013 at 02:03:41PM +0900, Tetsuo Handa wrote: Herbert Xu wrote: This way at least you'll have a working system until your initramfs tool is fixed to do the right thing. Thank you. But it is module-init-tools-3.9-21.el6_4 in RHEL 6.4. We can't wait until Red Hat backports