Re: [PATCH] CPU Jitter RNG: inclusion into kernel crypto API and /dev/random

2013-10-15 Thread Stephan Mueller
Am Montag, 14. Oktober 2013, 11:18:16 schrieb Sandy Harris: Hi Sandy, Could you please review the following code to see that the mix is function right in your eyes? However, having done that, I see no reason not to add mixing. Using bit() for getting one bit of input and rotl(x) for rotating

Re: [PATCH 2/3] ARM: at91/dt/trivial: before sama5d3, Atmel MPU were using at91 prefix

2013-10-15 Thread Nicolas Ferre
On 14/10/2013 19:09, Jean-Christophe PLAGNIOL-VILLARD : On 18:46 Mon 14 Oct , Nicolas Ferre wrote: Change the sha/aes/tdes compatibility string to match common case for the at91sam9g45 family which is to keep the at91 prefix. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com ---

[PATCH 1/5] crypto: authenc - Export key parsing helper function

2013-10-15 Thread Mathias Krause
AEAD key parsing is duplicated to multiple places in the kernel. Add a common helper function to consolidate that functionality. Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Mathias Krause mathias.kra...@secunet.com --- crypto/authenc.c

[PATCH 4/5] crypto: picoxcell - Simplify and harden key parsing

2013-10-15 Thread Mathias Krause
Use the common helper function crypto_authenc_extractkeys() for key parsing. Also ensure the auth key won't overflow the hash_ctx buffer. Cc: Jamie Iles ja...@jamieiles.com Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Mathias Krause

[PATCH 3/5] crypto: ixp4xx - Simplify and harden key parsing

2013-10-15 Thread Mathias Krause
Use the common helper function crypto_authenc_extractkeys() for key parsing. Also ensure the keys do fit into the corresponding buffers. Otherwise memory corruption might occur. Cc: Christian Hohnstaedt chohnsta...@innominate.com Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller

[PATCH 2/5] crypto: authencesn - Simplify key parsing

2013-10-15 Thread Mathias Krause
Use the common helper function crypto_authenc_extractkeys() for key parsing. Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Mathias Krause mathias.kra...@secunet.com --- crypto/authencesn.c | 26 -- 1 files changed, 4

[PATCH 0/5] Authenc key parsing consolidation

2013-10-15 Thread Mathias Krause
This series removes the code duplication of authenc key parsing by introducing a common helper function crypto_authenc_extractkeys() in patch 1. Patches 2 to 5 change all remaining places to use the new helper. Patches 3 and 4 also fix potential memory corruptions by ensuring the supplied keys

[PATCH 5/5] crypto: talitos - Simplify key parsing

2013-10-15 Thread Mathias Krause
Use the common helper function crypto_authenc_extractkeys() for key parsing. Cc: Kim Phillips kim.phill...@freescale.com Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Mathias Krause mathias.kra...@secunet.com --- Not tested as I've no such

[PATCH 1/3] crypto: atmel-tdes - add support for Device Tree

2013-10-15 Thread Nicolas Ferre
Add support for Device Tree and use of the DMA DT API to get the channels if needed. Documentation is added for these DT nodes. Initial code by: Nicolas Royer and Eukrea. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com --- .../devicetree/bindings/crypto/atmel-crypto.txt| 23

[PATCH 2/3] crypto: atmel-sha - add support for Device Tree

2013-10-15 Thread Nicolas Ferre
Add support for Device Tree and use of the DMA DT API to get the channels if needed. Documentation is added for these DT nodes. Initial code by: Nicolas Royer and Eukrea. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com --- .../devicetree/bindings/crypto/atmel-crypto.txt| 22 +

[PATCH 3/3] crypto: atmel-sha - add sha information to the log

2013-10-15 Thread Nicolas Ferre
Depending on peripheral capabilities, print SHA information at the end of the probe function. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/crypto/atmel-sha.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/atmel-sha.c