Re: scatterlist.h backtrace from crypto ccm module

2013-12-10 Thread Josh Boyer
On Fri, Dec 6, 2013 at 8:46 AM, Josh Boyer jwbo...@fedoraproject.org wrote: On Thu, Dec 5, 2013 at 10:47 AM, Tom Lendacky thomas.lenda...@amd.com wrote: On Thursday, December 05, 2013 09:03:02 AM Josh Boyer wrote: Hi All, We've had a report [1] of the backtrace below on the latest rawhide

Re: randconfig build error with next-20131210, in drivers/crypto/ccp

2013-12-10 Thread Tom Lendacky
On Monday, December 09, 2013 10:30:17 PM Jim Davis wrote: Building with the attached random configuration file, drivers/built-in.o: In function `ccp_init': /home/jim/linux/drivers/crypto/ccp/ccp-dev.c:402: undefined reference to `hwrng_register' drivers/built-in.o: In function

Re: randconfig build error with next-20131210, in drivers/crypto/ccp/ccp-pci.c

2013-12-10 Thread Tom Lendacky
On Tuesday, December 10, 2013 07:21:36 AM Jim Davis wrote: Building with the attached random configuration file, drivers/crypto/ccp/ccp-pci.c: In function ‘ccp_get_msix_irqs’: drivers/crypto/ccp/ccp-pci.c:44:20: error: array type has incomplete element type

Re: 3.11.4: kernel BUG at fs/buffer.c:1268

2013-12-10 Thread Jan Kara
On Tue 10-12-13 16:27:01, Jan Kara wrote: On Tue 10-12-13 04:35:28, George Spelvin wrote: One of those additional WARN_ON tests tripped, hooray! And it turned out to be in the ext4 metadata checksumming. To be precise, ext4_block_bitmap_csum_set() returned with irqs disabled, and kaboom.

[PATCH 0/3] crypto: ccp - code fixes/cleanup

2013-12-10 Thread Tom Lendacky
The following series implements fixes and cleanup for some reported errors and suggestions (sparse errors, randconfig build errors and pr_err usage). This patch series is based on the cryptodev-2.6 kernel tree. --- Tom Lendacky (3): crypto: ccp - Fix sparse warnings in ccp-crypto-sha.c

[PATCH 1/3] crypto: ccp - Fix sparse warnings in ccp-crypto-sha.c

2013-12-10 Thread Tom Lendacky
The sha initialization data generated the following sparse warnings: sparse: incorrect type in initializer (different base types) expected unsigned int got restricted __be32 [usertype] noident Change the initialization data type from u32 to __be32. Signed-off-by: Tom Lendacky

[PATCH 2/3] crypto: ccp - CCP Kconfig fixes

2013-12-10 Thread Tom Lendacky
Update the Kconfig to include PCI on the 'depends on' and add 'select HW_RANDOM' to insure the necessary PCI and HW_RANDOM functions are available/included in the build. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/crypto/Kconfig |2 +- drivers/crypto/ccp/Kconfig |

[PATCH 3/3] crypto: ccp - Remove user triggerable pr_err calls

2013-12-10 Thread Tom Lendacky
Remove the pr_err calls that are issued during parameter checking in some AES operations. This will eliminate the possibility of filling up syslog through these paths. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/crypto/ccp/ccp-crypto-aes-cmac.c |4 +---

[PATCH 4/5] ARM: mxs: dts: Enable DCP for MXS

2013-12-10 Thread Marek Vasut
Enable the DCP by default on both i.MX23 and i.MX28. Signed-off-by: Marek Vasut ma...@denx.de Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Cc: Fabio Estevam fabio.este...@freescale.com Cc: Shawn Guo shawn@linaro.org Cc: linux-crypto@vger.kernel.org Cc:

[PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-10 Thread Marek Vasut
When finishing the ahash request, the ahash_op_unaligned_done() will call complete() on the request. Yet, this will not call the correct complete callback. The correct complete callback was previously stored in the requests' private data, as seen in ahash_op_unaligned(). This patch restores the

[PATCH V3 3/5] crypto: mxs: Add Freescale MXS DCP driver

2013-12-10 Thread Marek Vasut
Add support for the MXS DCP block. The driver currently supports SHA-1/SHA-256 hashing and AES-128 CBC/ECB modes. The non-standard CRC32 is not yet supported. Signed-off-by: Marek Vasut ma...@denx.de Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Cc: Fabio

[PATCH V2 2/5] crypto: mxs: Remove the old DCP driver

2013-12-10 Thread Marek Vasut
Remove the old DCP driver as it had multiple severe issues. The driver will be replaced by a more robust implementation. Here is a short list of problems with this driver: 1) It only supports AES_CBC 2) The driver was apparently never ran behind anyone working with MXS. ie.: - Restarting the

Re: [PATCH V2 3/5] ARM: mxs: crypto: Add Freescale MXS DCP driver

2013-12-10 Thread Marek Vasut
On Tuesday, December 03, 2013 at 12:10:02 PM, Shawn Guo wrote: On Sun, Dec 01, 2013 at 10:20:21PM +0100, Marek Vasut wrote: Add support for the MXS DCP block. The driver currently supports SHA-1/SHA-256 hashing and AES-128 CBC/ECB modes. The non-standard CRC32 is not yet supported.