[PATCH 2/3] crypto: ccp-pci: Remove redundant dev_set_drvdata

2013-12-20 Thread Sachin Kamat
Driver core sets it to NULL upon probe failure or release. Signed-off-by: Sachin Kamat --- drivers/crypto/ccp/ccp-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-pci.c b/drivers/crypto/ccp/ccp-pci.c index 1fbeaf1856a8..f08c16d370cd 100644 --- a/drivers/crypto

[PATCH 3/3] crypto: talitos: Remove redundant dev_set_drvdata

2013-12-20 Thread Sachin Kamat
Driver core sets it to NULL upon probe failure or release. Signed-off-by: Sachin Kamat --- drivers/crypto/talitos.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index a3d2e9b88c41..5967667e1a8f 100644 --- a/drivers/crypto/talitos.c +

[PATCH 1/3] crypto: crypto4xx_core: Remove redundant dev_set_drvdata

2013-12-20 Thread Sachin Kamat
Driver core sets it to NULL upon probe failure or release. Signed-off-by: Sachin Kamat --- drivers/crypto/amcc/crypto4xx_core.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index efaf6302405f..37f9cc98ba17 1006

[PATCH -next] Re: randconfig build error with next-20131210, in drivers/crypto/ccp/ccp-pci.c

2013-12-20 Thread Tom Lendacky
On Thursday, December 19, 2013 11:35:09 AM Randy Dunlap wrote: > On 12/10/13 07:34, Tom Lendacky wrote: > > > > On Tuesday, December 10, 2013 07:21:36 AM Jim Davis wrote: > >> Building with the attached random configuration file, > >> > >> drivers/crypto/ccp/ccp-pci.c: In function ‘ccp_get_msix_i

Re: [PATCH] crypto: omap-sham: Fix Polling mode for larger blocks

2013-12-20 Thread Herbert Xu
On Wed, Dec 18, 2013 at 07:03:33PM +0530, Lokesh Vutla wrote: > Command "tcrypt sec=1 mode=403" give the follwoing error for Polling > mode: > root@am335x-evm:/# insmod tcrypt.ko sec=1 mode=403 > [...] > > [ 346.982754] test 15 ( 4096 byte blocks, 1024 bytes per update, 4 > updates): 4352 op

Re: [PATCH 1/2] crypto: AVX and AVX2 version of AESNI-GCM encode and decode

2013-12-20 Thread Herbert Xu
On Wed, Dec 11, 2013 at 02:28:41PM -0800, Tim Chen wrote: > We have added AVX and AVX2 routines that optimize AESNI-GCM encode/decode. > These routines are optimized for encrypt and decrypt of large buffers. > In tests we have seen up to 6% speedup for 1K, 11% speedup for 2K and > 18% speedup for 8

Re: [PATCH] crypto: caam - simplify and harden key parsing

2013-12-20 Thread Herbert Xu
On Thu, Dec 19, 2013 at 05:27:35PM +0200, Horia Geanta wrote: > Use the common helper function crypto_authenc_extractkeys() for key > parsing. > Also fix the key buffer overflow condition: use split key pad length > instead of authentication key length. > > Signed-off-by: Horia Geanta Patch appl

Re: [PATCH cryptodev] crypto: arch - use crypto_memneq instead of memcmp

2013-12-20 Thread Herbert Xu
On Wed, Dec 11, 2013 at 11:28:59AM +0100, Daniel Borkmann wrote: > Replace remaining occurences (just as we did in crypto/) under arch/*/crypto/ > that make use of memcmp() for comparing keys or authentication tags for > usage with crypto_memneq(). It can simply be used as a drop-in replacement > f

Re: [PATCH 0/3] crypto: ccp - code fixes/cleanup

2013-12-20 Thread Herbert Xu
On Tue, Dec 10, 2013 at 10:38:27AM -0600, Tom Lendacky wrote: > The following series implements fixes and cleanup for some reported > errors and suggestions (sparse errors, randconfig build errors and > pr_err usage). > > This patch series is based on the cryptodev-2.6 kernel tree. All applied.

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-20 Thread Herbert Xu
On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > When finishing the ahash request, the ahash_op_unaligned_done() will > call complete() on the request. Yet, this will not call the correct > complete callback. The correct complete callback was previously stored > in the requests' priva