Re: [PATCH 3/8 v4] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-24 Thread Tomasz Figa
Hi Naveen, On 15.01.2014 10:15, Naveen Krishna Chatradhi wrote: This patch adds new compatible and variant struct to support the SSS module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which 1. AES register are at an offset of 0x200 and 2. hash interrupt is not available

Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module

2014-01-24 Thread Tomasz Figa
Hi Naveen, Exynos5250 specific part looks good, but I have a little doubt in case of Exynos5420. On 15.01.2014 10:16, Naveen Krishna Chatradhi wrote: This patch adds gating clock for SSS(Security SubSystem) module on Exynos5250/5420. Signed-off-by: Naveen Krishna Chatradhi

Re: [PATCH 6/8 v4] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-24 Thread Tomasz Figa
Hi Naveen, On 15.01.2014 10:16, Naveen Krishna Chatradhi wrote: This patch adds the device tree node for SSS module found on Exynos5420 and Exynos5250 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com TO: linux-samsung-...@vger.kernel.org

Re: [PATCH 7/8 v4] crypto:s5p-sss: validate iv before memcpy

2014-01-24 Thread Tomasz Figa
On 15.01.2014 10:17, Naveen Krishna Chatradhi wrote: This patch adds code to validate iv buffer before trying to memcpy the contents Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v3: None drivers/crypto/s5p-sss.c |3 ++- 1 file changed, 2 insertions(+),

Re: Fix ccp_run_passthru_cmd dma variable assignments

2014-01-24 Thread Tom Lendacky
On 01/24/2014 12:39 PM, Dave Jones wrote: There are some suspicious looking lines of code in the new ccp driver, including one that assigns a variable to itself, and another that overwrites a previous assignment. This may have been a cut-and-paste error where 'src' was forgotten to be

[PATCH 1/4] crypto: ccp - Allow for selective disablement of crypto API algorithms

2014-01-24 Thread Tom Lendacky
Introduce module parameters that allow for disabling of a crypto algorithm by not registering the algorithm with the crypto API. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/crypto/ccp/ccp-crypto-main.c | 37 +++--- 1 file changed, 25

[PATCH 4/4] crypto: ccp - Perform completion callbacks using a tasklet

2014-01-24 Thread Tom Lendacky
Change from scheduling work to scheduling a tasklet to perform the callback operations. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/crypto/ccp/ccp-dev.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp-dev.c

[PATCH 3/4] crypto: ccp - Use a single queue for proper ordering of tfm requests

2014-01-24 Thread Tom Lendacky
Move to a single queue to serialize requests within a tfm. When testing using IPSec with a large number of network connections the per cpu tfm queuing logic was not working properly. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/crypto/ccp/ccp-crypto-main.c | 164

[PATCH 0/4] crypto: ccp - selective algorithm registration and ipsec-related fixes

2014-01-24 Thread Tom Lendacky
Patch 1: Allow for selectively disabling the registration of an algorithm family (sha or aes algorithms) via module parameters. Patch 2-4: Fix errors/issues that were found during IPSec testing. In order to prevent deadlocks with the networking code, the crypto callback was changed to run as a

[PATCH 2/4] crypto: ccp - Move HMAC calculation down to ccp ops file

2014-01-24 Thread Tom Lendacky
Move the support to perform an HMAC calculation into the CCP operations file. This eliminates the need to perform a synchronous SHA operation used to calculate the HMAC. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/crypto/ccp/ccp-crypto-sha.c | 130