Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-05 Thread Tadeusz Struk
Hi, On 11/02/2014 12:35 PM, Stephan Mueller wrote: > + * type: > + - blkcipher for symmetric block ciphers blkcipher for synchronous block ciphers > + - ablkcipher for asymmetric block ciphers ablkcipher for asynchronous block ciphers > + - cipher for sin

Re: [PATCH v2 03/11] crypto: Documentation - RNG API documentation

2014-11-05 Thread Joy M. Latten
Hi Stephan, Just one quick comment below... regards, Joy On Sun, 2014-11-02 at 21:36 +0100, Stephan Mueller wrote: > The API function calls exported by the kernel crypto API for RNGs to > be used by consumers are documented. > > Signed-off-by: Stephan Mueller > CC: Marek Vasut > --- > includ

Re: [PATCH v2 02/11] crypto: Documentation - userspace interface spec

2014-11-05 Thread Joy M. Latten
Hi Stephan, On Sun, 2014-11-02 at 21:36 +0100, Stephan Mueller wrote: > The userspace interface of the kernel crypto API is documented with > * a general explanation > * a discussion of the memory in-place operation > * the description of the message digest API > * the description of the symme

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-05 Thread Joy M. Latten
Hi Stephan, Great docs! I think they will be very useful! Thanks! I only have 2 comments below. regards, Joy On Sun, 2014-11-02 at 21:35 +0100, Stephan Mueller wrote: > The design of the kernel crypto API as well as hints to program with > the kernel crypto API are given. > > The documentation

Re: [PATCH v2] crypto: caam: fix error reporting

2014-11-05 Thread Kim Phillips
On Wed, 5 Nov 2014 11:21:24 +0200 Cristian Stoica wrote: > The error code returned by hardware is four bits wide with an expected > zero MSB. A hardware error condition where the error code can get between > 0x8 and 0xf will trigger an out of bound array access on the error > message table. > Thi

Re: [PATCH] crypto: caam: fix error reporting

2014-11-05 Thread Cristian Stoica
Hi Kim, On 11/04/2014 06:57 PM, Kim Phillips wrote: > On Tue, 4 Nov 2014 10:57:57 +0200 > Cristian Stoica wrote: >> Do you want me to drop the patch and pretend there is nothing to see? > > no, fixing potential bugs preemptively is fine; I'd just like to > know that's the case: it wasn't clear

[PATCH v2] crypto: caam: fix error reporting

2014-11-05 Thread Cristian Stoica
The error code returned by hardware is four bits wide with an expected zero MSB. A hardware error condition where the error code can get between 0x8 and 0xf will trigger an out of bound array access on the error message table. This patch fixes the invalid array access following such an error and re