Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-29 Thread Herbert Xu
On Tue, Apr 28, 2015 at 09:52:32PM +0200, Boris Brezillon wrote: > > In particular, I'd like to discuss the threaded-irq approach taken in > this driver (other drivers are using tasklets). > The main reason behind this choice is the fact that crypto engines > are quite fast, and I'm worried about

Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-29 Thread mancha security
Hi Daniel et al. Looks good from here. By the way, has anyone been able to verify that __memory_barrier provides DSE protection under various optimizations? Unfortunately, I don't have ready access to ICC at the moment or I'd test it myself. --mancha PS It would be nice if memset_s were univer

Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-29 Thread mancha security
On Wed, Apr 29, 2015 at 04:01:19PM +0200, Daniel Borkmann wrote: > On 04/29/2015 03:08 PM, mancha security wrote: > ... > >By the way, has anyone been able to verify that __memory_barrier > >provides DSE protection under various optimizations? Unfortunately, I > >don't have ready access to ICC at t

Re: [PATCH crypto-2.6] lib: make memzero_explicit more robust against dead store elimination

2015-04-29 Thread mancha security
On Thu, Apr 30, 2015 at 01:43:07AM +0200, Daniel Borkmann wrote: > On 04/29/2015 04:54 PM, mancha security wrote: > >On Wed, Apr 29, 2015 at 04:01:19PM +0200, Daniel Borkmann wrote: > >>On 04/29/2015 03:08 PM, mancha security wrote: > >>... > >>>By the way, has anyone been able to verify that __mem