On Mon, May 25, 2015 at 07:53:41PM +0800, Herbert Xu wrote:
On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote:
When you have my code local, simply execute libkcapi/test/kcapi -y twice or
three times. That triggered the crash.
Aha that's what I was missing. I'll look into
Am Freitag, 22. Mai 2015, 15:19:23 schrieb Herbert Xu:
Hi Herbert,
On Fri, May 22, 2015 at 09:16:08AM +0200, Stephan Mueller wrote:
Thanks for the pointer, but there I do not really see the functionality I
am looking for. I see patch 10/16 which seems to indicate that the geniv
logic is
Am Dienstag, 26. Mai 2015, 14:24:33 schrieb Herbert Xu:
Hi Herbert,
On Mon, May 25, 2015 at 07:53:41PM +0800, Herbert Xu wrote:
On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote:
When you have my code local, simply execute libkcapi/test/kcapi -y twice
or
three times.
The newly added AEAD user-space isn't quite ready for prime time
just yet. In particular it is conflicting with the AEAD single
SG list interface change so this patch disables it now.
Once the SG list stuff is completely done we can then renable
this interface.
Signed-off-by: Herbert Xu
On Tue, May 26, 2015 at 08:44:29AM +0200, Stephan Mueller wrote:
Confirmed. I see no more issues on the AF_ALG side.
OK it works but there is a more serious issue. In particular, the
user-space interface only provides spaces for the AD in the source
and not in the destination.
That means if
Am Dienstag, 26. Mai 2015, 15:21:52 schrieb Herbert Xu:
Hi Herbert,
On Tue, May 26, 2015 at 08:39:56AM +0200, Stephan Mueller wrote:
May I also ask where I can find the generated IV when using
rfc4106(gcm(aes))?
You need to use the IV generator, seqniv(rfc4106(gcm(aes)))
Thank you, that
On Tue, May 26, 2015 at 10:15:37AM +0200, Stephan Mueller wrote:
I fully understand that. But the current patch set that we discuss modifies
the IPSEC implementation of esp_ouput to use the new interface. Therefore, to
use rfc4106(gcm(aes)) *with* the IV generator (i.e. to get the old
On Tue, May 26, 2015 at 09:56:17AM +0200, Stephan Mueller wrote:
Actually, I mean the real in-kernel crypto API: the IKE daemon would set up
the SA via XFRM where the rfc4106(gcm(aes)) cipher is set, is it not? So,
user
space is responsible to set the right IPSEC cipher.
As that user
Am Dienstag, 26. Mai 2015, 15:36:05 schrieb Herbert Xu:
Hi Herbert,
In order to allow this to be done I'm going to disable the AEAD
user-space interface in 4.1 so that we have time to fix it properly
for 4.2.
Ok. Would you look into that one or shall I do that?
Ciao
Stephan
--
To unsubscribe
Am Dienstag, 26. Mai 2015, 08:39:56 schrieb Stephan Mueller:
Hi,
Am Freitag, 22. Mai 2015, 15:19:23 schrieb Herbert Xu:
Hi Herbert,
On Fri, May 22, 2015 at 09:16:08AM +0200, Stephan Mueller wrote:
Thanks for the pointer, but there I do not really see the functionality I
am looking for. I
On Tue, May 26, 2015 at 08:39:56AM +0200, Stephan Mueller wrote:
May I also ask where I can find the generated IV when using
rfc4106(gcm(aes))?
You need to use the IV generator, seqniv(rfc4106(gcm(aes)))
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page:
On Tue, May 26, 2015 at 03:38:58PM +0800, Herbert Xu wrote:
On Tue, May 26, 2015 at 09:37:09AM +0200, Stephan Mueller wrote:
- the current IKE implementations use rfc4106(gcm(aes)). They would need to
use seqniv(rfc4106(gcm(aes))) depending on the kernel version. So, we have
a
clear
On Tue, May 26, 2015 at 09:37:09AM +0200, Stephan Mueller wrote:
- the current IKE implementations use rfc4106(gcm(aes)). They would need to
use seqniv(rfc4106(gcm(aes))) depending on the kernel version. So, we have a
clear change in the user space API where the old configuration even works
On Tue, May 26, 2015 at 09:57:51AM +0200, Stephan Mueller wrote:
Ok. Would you look into that one or shall I do that?
I'll reenable it immediately after the patch to convert it to
the new interface is merged.
Cheers,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page:
Am Dienstag, 26. Mai 2015, 15:38:59 schrieb Herbert Xu:
Hi Herbert,
On Tue, May 26, 2015 at 09:37:09AM +0200, Stephan Mueller wrote:
- the current IKE implementations use rfc4106(gcm(aes)). They would need to
use seqniv(rfc4106(gcm(aes))) depending on the kernel version. So, we have
a
clear
Hi Linus:
This push disables the newly (4.1) added user-space AEAD interface
so that we can fix issues in the underlying kernel AEAD interface.
Once the new kernel AEAD interface is ready we can then reenable
the user-space AEAD interface.
Please pull from
Am Dienstag, 26. Mai 2015, 16:18:01 schrieb Herbert Xu:
Hi Herbert,
This is all in the patch series that you're responding. So please
actually read it rather than making assumptions :)
Sorry, you are right -- I overlooked the xfrm_algo_desc change. Thanks for
helping.
Ciao
Stephan
--
To
Dear Boris Brezillon,
On Tue, 26 May 2015 11:03:45 +0200, Boris Brezillon wrote:
There is no clocks property. After a quick look on the datasheet, indeed I
didn't
find any clock which match the CESA. In this case you should update the
binding
documentation by adding that the clock is
On Tue, 26 May 2015 09:06:29 +
Jason Cooper ja...@lakedaemon.net wrote:
On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote:
Jason, Gregory,
On Mon, 25 May 2015 16:46:51 +
Jason Cooper ja...@lakedaemon.net wrote:
On Mon, May 25, 2015 at 05:39:13PM +0200,
On Mon, 25 May 2015 17:10:37 +0200
Gregory CLEMENT gregory.clem...@free-electrons.com wrote:
Hi Boris,
On 22/05/2015 15:34, Boris Brezillon wrote:
Enable the crypto IP on armada-xp-gp.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
---
On Mon, May 18, 2015 at 10:06:55AM -0700, Dan Williams wrote:
On Mon, May 18, 2015 at 2:14 AM, Maxime Ripard
maxime.rip...@free-electrons.com wrote:
Hi Dan,
On Wed, May 13, 2015 at 09:00:46AM -0700, Dan Williams wrote:
On Wed, May 13, 2015 at 2:17 AM, Maxime Ripard
On Tue, May 26, 2015 at 11:10:51AM +0200, Boris Brezillon wrote:
On Tue, 26 May 2015 09:06:29 +
Jason Cooper ja...@lakedaemon.net wrote:
On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote:
Jason, Gregory,
On Mon, 25 May 2015 16:46:51 +
Jason Cooper
On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote:
Jason, Gregory,
On Mon, 25 May 2015 16:46:51 +
Jason Cooper ja...@lakedaemon.net wrote:
On Mon, May 25, 2015 at 05:39:13PM +0200, Gregory CLEMENT wrote:
Hi Boris, Arnaud,
On 22/05/2015 15:34, Boris Brezillon
Hi Gregory,
On Mon, 25 May 2015 17:33:24 +0200
Gregory CLEMENT gregory.clem...@free-electrons.com wrote:
Hi Boris, Arnaud,
On 22/05/2015 15:34, Boris Brezillon wrote:
From: Arnaud Ebalard a...@natisbad.org
Add crypto related nodes in armada-370.dtsi.
Signed-off-by: Arnaud
On Tue, 26 May 2015 11:10:41 +0200
Thomas Petazzoni thomas.petazz...@free-electrons.com wrote:
Dear Boris Brezillon,
On Tue, 26 May 2015 11:03:45 +0200, Boris Brezillon wrote:
There is no clocks property. After a quick look on the datasheet, indeed
I didn't
find any clock which
On Tue, 26 May 2015 10:59:36 +0200, Boris Brezillon
boris.brezil...@free-electrons.com wrote:
snip
As the crypto engine really depend on the SoC itself and not of the
board,
what about updating the dts of the other board using an Armada XP?
But that means introducing changes I haven't
On Tue, May 26, 2015 at 11:22:45AM +0200, Imre Kaloz wrote:
On Tue, 26 May 2015 10:59:36 +0200, Boris Brezillon
boris.brezil...@free-electrons.com wrote:
snip
As the crypto engine really depend on the SoC itself and not of
the board,
what about updating the dts of the other board using
Hi Paul,
this patch is also for omap2... Can you review it too?
On Saturday 28 February 2015 17:24:36 Pavel Machek wrote:
On Thu 2015-02-26 14:49:52, Pali Rohár wrote:
Register crypto hwmod links only if they are not disabled in DT.
If DT information is missing, enable them only for GP
The following patches are included in this driver update series:
- Remove the checking and setting of the device dma_mask field
- Remove an unused field from a structure to help avoid any confusion
- Protect against poorly marked end of scatter-gather list
This patch series is based on
Remove the length field from the ccp_sg_workarea since it is unused.
Signed-off-by: Tom Lendacky thomas.lenda...@amd.com
---
drivers/crypto/ccp/ccp-ops.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 71f2e3c..542453c
The underlying device support will set the device dma_mask pointer
if DMA is set up properly for the device. Remove the check for and
assignment of dma_mask when it is null. Instead, just error out if
the dma_set_mask_and_coherent function fails because dma_mask is null.
Signed-off-by: Tom
Scatter gather lists can be created with more available entries than are
actually used (e.g. using sg_init_table() to reserve a specific number
of sg entries, but in actuality using something less than that based on
the data length). The caller sometimes fails to mark the last entry
with
[ adding Boaz as this discussion has implications for ore_raid ]
On Tue, May 26, 2015 at 2:45 AM, Maxime Ripard
maxime.rip...@free-electrons.com wrote:
On Mon, May 18, 2015 at 10:06:55AM -0700, Dan Williams wrote:
On Mon, May 18, 2015 at 2:14 AM, Maxime Ripard
maxime.rip...@free-electrons.com
Hello Herbert Xu,
The patch a10f554fa7e0: crypto: echainiv - Add encrypted chain IV
generator from May 21, 2015, leads to the following static checker
warning:
crypto/echainiv.c:492 echainiv_alloc()
warn: 'inst' isn't an ERR_PTR
crypto/echainiv.c
435 static struct
* Peter Ujfalusi peter.ujfal...@ti.com [150526 06:28]:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we received including
-EPROBE_DEFER
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Greg Kroah-Hartman
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Herbert Xu
On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we received including
-EPROBE_DEFER
I think you typed the function name wrong here :(
--
To unsubscribe
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Ulf Hansson
dma_request_slave_channel_compat() 'eats' up the returned error codes which
prevents drivers using the compat call to be able to do deferred probing.
The new wrapper is identical in functionality but it will return with error
code in case of failure and will pass the -EPROBE_DEFER to the caller
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we received including
-EPROBE_DEFER
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Ulf Hansson ulf.hans...@linaro.org
---
drivers/mmc/host/omap_hsmmc.c | 22
The driver will not probe without valid DMA channels so no need to check
if they are valid when the module is removed.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Ulf Hansson ulf.hans...@linaro.org
---
drivers/mmc/host/omap_hsmmc.c | 6 ++
1 file changed, 2 insertions(+), 4
of_dma_request_slave_channel should return either pointer for valid
dma_chan or ERR_PTR() error code, NULL is not expected to be returned.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Grant Likely grant.lik...@linaro.org
CC: Rob Herring robh...@kernel.org
---
include/linux/of_dma.h |
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Ulf Hansson
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. In case of error, return the error code we received including
-EPROBE_DEFER
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Hi,
Vinod: as I promised: https://lkml.org/lkml/2015/5/8/80
With this series it is possible to put omap-dma or edma to even late_initcall
and the drivers will figure out the load order fine(ish).
We need to add dma_request_slave_channel_compat_reason() which is the equivalent
of
dmaengine provides a wrapper function to handle DT and non DT boots when
requesting DMA channel. Use that instead of checking for of_node in the
platform driver.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Mark Brown broo...@kernel.org
CC: Jarkko Nikula jarkko.nik...@bitmer.com
CC:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Mark Brown
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Herbert Xu
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channel. Only fall back to polling mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Herbert Xu
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channel. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Laurent Pinchart
Am Dienstag, 26. Mai 2015, 15:57:59 schrieb Herbert Xu:
Hi Herbert,
On Tue, May 26, 2015 at 09:56:17AM +0200, Stephan Mueller wrote:
Actually, I mean the real in-kernel crypto API: the IKE daemon would set up
the SA via XFRM where the rfc4106(gcm(aes)) cipher is set, is it not? So,
user space
On Tue, May 26, 2015 at 04:26:06PM +0300, Peter Ujfalusi wrote:
Switch to use ma_request_slave_channel_compat_reason() to request the DMA
channels. Only fall back to pio mode if the error code returned is not
-EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER.
I've got two
The vti6_rcv_cb and vti_rcv_cb calls were leaving the skb-mark modified
after completing the function. This resulted in the original skb-mark
value being lost. Since we only need skb-mark to be set for
xfrm_policy_check we can pull the assignment into the rcv_cb calls and then
just restore the
Instead of modifying skb-mark we can simply modify the flowi_mark that is
generated as a result of the xfrm_decode_session. By doing this we don't
need to actually touch the skb-mark and it can be preserved as it passes
out through the tunnel.
Signed-off-by: Alexander Duyck
This change makes it so that if a tunnel is defined we just use the mark
from the tunnel instead of the mark from the skb header. By doing this we
can avoid the need to set skb-mark inside of the tunnel receive functions.
Signed-off-by: Alexander Duyck alexander.h.du...@redhat.com
---
55 matches
Mail list logo
