crypto: broken Kconfig option CRYPTO_NULL2

2015-08-19 Thread Valentin Rothberg
Hi Herbert, your commit 149a39717dcc ("crypto: aead - Add type-safe geniv init/exit helpers") has shown up in Linux next (i.e., next-20150818) adding the following lines of code to crypto/Kconfig: @@ -150,12 +152,15 @@ config CRYPTO_GF128MUL [...] +config CRYPTO_NULL2 + select CRYPTO_ALGAP

Re: crypto: broken Kconfig option CRYPTO_NULL2

2015-08-19 Thread Herbert Xu
On Wed, Aug 19, 2015 at 09:49:37AM +0200, Valentin Rothberg wrote: > > your commit 149a39717dcc ("crypto: aead - Add type-safe geniv > init/exit helpers") has shown up in Linux next (i.e., next-20150818) > adding the following lines of code to crypto/Kconfig: Thanks but this was fixed two days ag

Re: crypto: broken Kconfig option CRYPTO_NULL2

2015-08-19 Thread Valentin Rothberg
On Wed, Aug 19, 2015 at 9:52 AM, Herbert Xu wrote: > On Wed, Aug 19, 2015 at 09:49:37AM +0200, Valentin Rothberg wrote: >> >> your commit 149a39717dcc ("crypto: aead - Add type-safe geniv >> init/exit helpers") has shown up in Linux next (i.e., next-20150818) >> adding the following lines of code

Recent AEAD change: testmgr.c change needed?

2015-08-19 Thread Stephan Mueller
Hi Herbert, The recent AEAD change seems to trigger a need to change something in testmgr.c. I ran my test tool trying to invoke all possible permutations of cra_name and cra_driver_name ciphers and got the following: [11152.816179] alg: No test for gcm_base(ctr(aes-asm),ghash-generic) (gcm_ba

cbc(aes-aesni) a givcipher?

2015-08-19 Thread Stephan Mueller
Hi Herbert, with the latest cryptodev-2.6 tree I find the following: name : cbc(aes) driver : cbc(aes-aesni) module : kernel priority : 300 refcnt : 1 selftest : passed internal : no type : givcipher async: no blocksize: 16 min keysize :

Re: cbc(aes-aesni) a givcipher?

2015-08-19 Thread Stephan Mueller
Am Mittwoch, 19. August 2015, 12:11:03 schrieb Stephan Mueller: Hi, > Hi Herbert, > > with the latest cryptodev-2.6 tree I find the following: > > name : cbc(aes) > driver : cbc(aes-aesni) > module : kernel > priority : 300 > refcnt : 1 > selftest : passed > in

Re: Recent AEAD change: testmgr.c change needed?

2015-08-19 Thread Herbert Xu
Hi Staphan: On Wed, Aug 19, 2015 at 11:48:05AM +0200, Stephan Mueller wrote: > > The recent AEAD change seems to trigger a need to change something in > testmgr.c. I ran my test tool trying to invoke all possible permutations of > cra_name and cra_driver_name ciphers and got the following: > >

Re: cbc(aes-aesni) a givcipher?

2015-08-19 Thread Herbert Xu
On Wed, Aug 19, 2015 at 12:31:13PM +0200, Stephan Mueller wrote: > > > > with the latest cryptodev-2.6 tree I find the following: > > > > name : cbc(aes) > > driver : cbc(aes-aesni) > > module : kernel > > priority : 300 > > refcnt : 1 > > selftest : passed > > i

un4i-ss-cipher.c warning

2015-08-19 Thread Michal Suchanek
Hello, when building a kernel with sunxi crypto driver as merged into the sinxi-wip branch I get a compiler warning. I am not sure this is the latest version of the driver. It does not seem to be in mainline yet. Thanks Michal In file included from /scratch/build/linux/include/linux/printk.h:2

Re: [PATCH] crypto: sahara: Use dmam_alloc_coherent

2015-08-19 Thread Herbert Xu
On Tue, Aug 18, 2015 at 11:36:05AM +0530, Vaishali Thakkar wrote: > This patch moves the data allocated using dma_alloc_coherent to the > corresponding managed interface. To be compatible with the change, > various gotos are replaced with direct returns and unneeded labels > are dropped. > > Signe

Re: [PATCH] crypto: cmac - allow usage in FIPS mode

2015-08-19 Thread Herbert Xu
On Wed, Aug 19, 2015 at 08:42:07AM +0200, Stephan Mueller wrote: > CMAC is an approved cipher in FIPS 140-2. The patch allows the use > of CMAC with TDES and AES in FIPS mode. > > Signed-off-by: Stephan Mueller Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP K

Re: [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C

2015-08-19 Thread Vinod Koul
On Thu, Jul 30, 2015 at 05:41:05PM +0530, Rameshwar Prasad Sahu wrote: > This patch adds support for new feature CRC32C calculation in > dmaengine framework. Looks okay can you please update Documentation also -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-crypto"

Re: un4i-ss-cipher.c warning

2015-08-19 Thread Herbert Xu
On Wed, Aug 19, 2015 at 04:35:36PM +0200, Michal Suchanek wrote: > Hello, > > when building a kernel with sunxi crypto driver as merged into the > sinxi-wip branch I get a compiler warning. > > I am not sure this is the latest version of the driver. It does not > seem to be in mainline yet. The

Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine

2015-08-19 Thread Vinod Koul
On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote: > + /* Invalidate unused source address field */ > + for (; i < 4; i++) > + xgene_dma_invalidate_buffer(xgene_dma_lookup_ext8(desc2, i)); > + > + /* Check whether requested buffer processed */ > + if

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-08-19 Thread Vinod Koul
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: > + nents = sg_nents(req->src); > + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE); > + if (!sg_count) { > + dev_err(dev, "Failed to map src sg"); > + return -ENOMEM; mapping error

Re: [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C

2015-08-19 Thread Rameshwar Sahu
Hi Vinod, On Thu, Aug 20, 2015 at 10:56 AM, Vinod Koul wrote: > On Thu, Jul 30, 2015 at 05:41:05PM +0530, Rameshwar Prasad Sahu wrote: >> This patch adds support for new feature CRC32C calculation in >> dmaengine framework. > > Looks okay can you please update Documentation also Thanks, I will u

[PATCH v2 0/8] zram: introduce crypto compress noctx API and use it on zram

2015-08-19 Thread Joonsoo Kim
This patchset makes zram to use crypto API in order to support more compression algorithm. The reason we need to support vairous compression algorithms is that zram's performance is highly depend on workload and compression algorithm and architecture. Every compression algorithm has it's own stron

[PATCH v2 1/8] crypto: support (de)compression API that doesn't require tfm object

2015-08-19 Thread Joonsoo Kim
Until now, tfm object embeds (de)compression context in it and (de)compression in crypto API requires tfm object to use this context. But, there are some algorithms that doesn't need such context to operate. Therefore, this patch introduce new crypto compression API that call (de)compression functi

[PATCH v2 8/8] zram: use decompress_noctx

2015-08-19 Thread Joonsoo Kim
Crypto subsystem supports noctx API which doesn't require tfm. To get tfm in zram, we need zstrm and it is limited resource. If we uses noctx API, we don't need to get zstrm so that we get much better performance when zstrm is insufficient. This patch restores zram's performance to the time that z

[PATCH v2 6/8] zram: change zcomp_compress interface

2015-08-19 Thread Joonsoo Kim
zram regards zstrm's buffer as compression destination buffer, but, it is not intuitive and there is no document about it. Providing destination buffer to zcomp_compress() directly seems more intuitive interface to me so this patch changes zcomp_compress interface. Signed-off-by: Joonsoo Kim ---

[PATCH v2 7/8] zram: use crypto API for compression

2015-08-19 Thread Joonsoo Kim
Until now, zram uses compression algorithm through direct call to core algorithm function, but, it has drawback that we need to add compression algorithm manually to zram if needed. Without this work, we cannot utilize various compression algorithms in the system. Moreover, to add new compression a

[PATCH v2 3/8] crypyo/lz4: support decompress_noctx

2015-08-19 Thread Joonsoo Kim
lz4's decompression doesn't requires any scratch buffer so it doesn't need tfm context. Hence, it can support crypto compression noctx API and this patch implements it. Signed-off-by: Joonsoo Kim --- crypto/lz4.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/8] crypto/lz4hc: support decompress_noctx

2015-08-19 Thread Joonsoo Kim
lz4hc's decompression doesn't requires any scratch buffer so it doesn't need tfm context. Hence, it can support crypto compression noctx API and this patch implements it. Signed-off-by: Joonsoo Kim --- crypto/lz4hc.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff -

[PATCH v2 5/8] crypto/842: support decompress_noctx

2015-08-19 Thread Joonsoo Kim
842's decompression doesn't requires any scratch buffer so it doesn't need tfm context. Hence, it can support crypto compression noctx API and this patch implements it. Signed-off-by: Joonsoo Kim --- crypto/842.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/crypto/8

[PATCH v2 2/8] crypto/lzo: support decompress_noctx

2015-08-19 Thread Joonsoo Kim
lzo's decompression doesn't requires any scratch buffer so it doesn't need tfm context. Hence, it can support crypto compression noctx API and this patch implements it. Signed-off-by: Joonsoo Kim --- crypto/lzo.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --gi

Re: un4i-ss-cipher.c warning

2015-08-19 Thread Maxime Ripard
On Thu, Aug 20, 2015 at 01:29:03PM +0800, Herbert Xu wrote: > On Wed, Aug 19, 2015 at 04:35:36PM +0200, Michal Suchanek wrote: > > Hello, > > > > when building a kernel with sunxi crypto driver as merged into the > > sinxi-wip branch I get a compiler warning. > > > > I am not sure this is the lat

Re: un4i-ss-cipher.c warning

2015-08-19 Thread Herbert Xu
On Thu, Aug 20, 2015 at 08:39:00AM +0200, Maxime Ripard wrote: > > Not in the dev_dbg call line 258. If ileft was negative or null, todo > isn't assigned to anything. If ileft starts out being <= 0, then oleft == ileft will also be <= 0, in which case the loop never executes. Cheers, -- Email: H

Re: [PATCH v2 1/8] crypto: support (de)compression API that doesn't require tfm object

2015-08-19 Thread Herbert Xu
On Thu, Aug 20, 2015 at 03:34:57PM +0900, Joonsoo Kim wrote: > Until now, tfm object embeds (de)compression context in it and > (de)compression in crypto API requires tfm object to use > this context. But, there are some algorithms that doesn't need > such context to operate. Therefore, this patch

Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine

2015-08-19 Thread Rameshwar Sahu
Hi Vinod, On Thu, Aug 20, 2015 at 11:10 AM, Vinod Koul wrote: > On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote: >> + /* Invalidate unused source address field */ >> + for (; i < 4; i++) >> + xgene_dma_invalidate_buffer(xgene_dma_lookup_ext8(desc2, i)); >