Re: un4i-ss-cipher.c warning

2015-08-20 Thread Herbert Xu
On Thu, Aug 20, 2015 at 03:56:39PM +0200, Corentin LABBE wrote: > > Thanks for the report, strange that I do not have that warning. > todo is always initialized, since oleft and ileft are always > 0 at start. > But setting todo to 0 is a simple fix. > The following patch will suppress the warning.

Re: un4i-ss-cipher.c warning

2015-08-20 Thread Corentin LABBE
On 19/08/2015 16:35, Michal Suchanek wrote: Hello, when building a kernel with sunxi crypto driver as merged into the sinxi-wip branch I get a compiler warning. I am not sure this is the latest version of the driver. It does not seem to be in mainline yet. Thanks Michal In file included from

[PATCH] crypto: hash - Add AHASH_REQUEST_ON_STACK

2015-08-20 Thread Herbert Xu
This patch adds the helper AHASH_REQUEST_ON_STACK for those users of ahash that are synchronous only. Signed-off-by: Herbert Xu --- include/crypto/hash.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/crypto/hash.h b/include/crypto/hash.h index 57c8a6e..8e920b4 100644 --- a

Re: [PATCH v2 1/8] crypto: support (de)compression API that doesn't require tfm object

2015-08-20 Thread Joonsoo Kim
On Thu, Aug 20, 2015 at 03:50:35PM +0800, Herbert Xu wrote: > On Thu, Aug 20, 2015 at 04:52:17PM +0900, Joonsoo Kim wrote: > > > > Hmm... I guess there is no problem. crypto_alg object fetched by > > crypto_get_comp() introduced in this patch could be hardware device > > algorithm which is same on

Re: [PATCH v2 1/8] crypto: support (de)compression API that doesn't require tfm object

2015-08-20 Thread Herbert Xu
On Thu, Aug 20, 2015 at 04:52:17PM +0900, Joonsoo Kim wrote: > > Hmm... I guess there is no problem. crypto_alg object fetched by > crypto_get_comp() introduced in this patch could be hardware device > algorithm which is same one that we can eventually fetch from tfm object. > So, this approach wo

Re: [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C

2015-08-20 Thread Rameshwar Sahu
On Thu, Aug 20, 2015 at 12:38 PM, Vinod Koul wrote: > On Thu, Aug 20, 2015 at 11:59:07AM +0530, Rameshwar Sahu wrote: >> Hi Vinod, >> >> On Thu, Aug 20, 2015 at 10:56 AM, Vinod Koul wrote: >> > On Thu, Jul 30, 2015 at 05:41:05PM +0530, Rameshwar Prasad Sahu wrote: >> >> This patch adds support fo

Re: [PATCH v2 1/8] crypto: support (de)compression API that doesn't require tfm object

2015-08-20 Thread Joonsoo Kim
On Thu, Aug 20, 2015 at 02:47:28PM +0800, Herbert Xu wrote: > On Thu, Aug 20, 2015 at 03:34:57PM +0900, Joonsoo Kim wrote: > > Until now, tfm object embeds (de)compression context in it and > > (de)compression in crypto API requires tfm object to use > > this context. But, there are some algorithms

Re: Recent AEAD change: testmgr.c change needed?

2015-08-20 Thread Herbert Xu
On Wed, Aug 19, 2015 at 08:45:50PM +0800, Herbert Xu wrote: > > > [11154.278466] alg: No test for ccm_base(ctr(aes-asm),aes-asm) > > (ccm_base(ctr(aes-asm),aes-asm)) > > [11174.819535] alg: No test for gcm(aes-asm) (gcm_base(ctr(aes-asm),ghash- > > clmulni)) > > [11174.819610] alg: No test for rfc

[PATCH 2/2] crypto: testmgr - Use new skcipher interface

2015-08-20 Thread Herbert Xu
This patch replaces uses of blkcipher and ablkcipher with the new skcipher interface. Signed-off-by: Herbert Xu --- crypto/testmgr.c | 61 --- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.

[PATCH 1/2] crypto: skcipher - Add top-level skcipher interface

2015-08-20 Thread Herbert Xu
This patch introduces the crypto skcipher interface which aims to replace both blkcipher and ablkcipher. It's very similar to the existing ablkcipher interface. The main difference is the removal of the givcrypt interface. In order to make the transition easier for blkcipher users, there is a he

[PATCH 0/2] crypto: skcipher - Introduce new skcipher interface

2015-08-20 Thread Herbert Xu
Hi: These two patches introduce a new skcipher interface that aims to replace the existing blkcipher and ablkcipher interfaces. A bit of history, the blkcipher interface was originally split from the cipher interface in order to differentiate the underly block cipher algorithm from the modes such

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-08-20 Thread Vinod Koul
On Thu, Aug 20, 2015 at 12:31:44PM +0530, Rameshwar Sahu wrote: > Hi Vinod, > > On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul wrote: > > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: > >> + nents = sg_nents(req->src); > >> + sg_count = dma_map_sg(dev, req->src, nen

Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine

2015-08-20 Thread Vinod Koul
On Thu, Aug 20, 2015 at 12:23:50PM +0530, Rameshwar Sahu wrote: > Hi Vinod, > > On Thu, Aug 20, 2015 at 11:10 AM, Vinod Koul wrote: > > On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote: > >> + /* Invalidate unused source address field */ > >> + for (; i < 4; i++) > >>

Re: [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C

2015-08-20 Thread Vinod Koul
On Thu, Aug 20, 2015 at 11:59:07AM +0530, Rameshwar Sahu wrote: > Hi Vinod, > > On Thu, Aug 20, 2015 at 10:56 AM, Vinod Koul wrote: > > On Thu, Jul 30, 2015 at 05:41:05PM +0530, Rameshwar Prasad Sahu wrote: > >> This patch adds support for new feature CRC32C calculation in > >> dmaengine framewor

Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

2015-08-20 Thread Rameshwar Sahu
Hi Vinod, On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul wrote: > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote: >> + nents = sg_nents(req->src); >> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE); >> + if (!sg_count) { >> + dev_err(dev,