Re: [PATCH v3] crypto: omap-aes: Add support for GCM mode

2015-09-20 Thread Matthijs van Duin
On 15 September 2015 at 15:28, Lokesh Vutla wrote: > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -293,6 +293,7 @@ config CRYPTO_DEV_OMAP_AES > depends on ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP2PLUS > select CRYPTO_AES > select CRYPTO_BLKCIPHER > +

[PATCH] crypto: crc32c-pclmul: use .rodata instead of .rotata

2015-09-20 Thread Nicolas Iooss
Module crc32c-intel uses a special read-only data section named .rotata. This section is defined for K_table, and its name seems to be a spelling mistake for .rodata. Fixes: 473946e674eb ("crypto: crc32c-pclmul - Shrink K_table to 32-bit words") Signed-off-by: Nicolas Iooss --- arch/x86/crypto/c

Re: [PATCH v3 6/9] zram: make stream find and release functions static

2015-09-20 Thread Minchan Kim
On Fri, Sep 18, 2015 at 02:19:21PM +0900, Joonsoo Kim wrote: > From: Sergey Senozhatsky > > Hide (make static) zstrm find and release function and introduce > zcomp_compress_begin()/zcomp_compress_end(). We will have begin > and end functions around compression (this patch) and decompression > (n

Re: [PATCH v3 7/9] zram: pass zstrm down to decompression path

2015-09-20 Thread Minchan Kim
On Fri, Sep 18, 2015 at 02:19:22PM +0900, Joonsoo Kim wrote: > From: Sergey Senozhatsky > > Introduce zcomp_decompress_begin()/zcomp_decompress_end() as a > preparation for crypto API-powered zcomp. > > Change zcomp_decompress() signature to require zstrm parameter. > > Unlike zcomp_compress_be

Re: [PATCH v3 8/9] zram: use crypto API for compression

2015-09-20 Thread Minchan Kim
Hi Joonsoo, On Fri, Sep 18, 2015 at 02:19:23PM +0900, Joonsoo Kim wrote: > Until now, zram uses compression algorithm through direct call > to core algorithm function, but, it has drawback that we need to add > compression algorithm manually to zram if needed. Without this work, > we cannot utiliz

Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API

2015-09-20 Thread Minchan Kim
On Fri, Sep 18, 2015 at 02:19:24PM +0900, Joonsoo Kim wrote: > Crypto subsystem now supports decompress_noctx API that requires > special tfm_noctx. This tfm can be shared by multiple concurrent > decompress user because this API doesn't rely on this tfm object > except to fetch decompress function

Re: [PATCH v3 0/9] zram: introduce crypto decompress noctx API and use it on zram

2015-09-20 Thread Minchan Kim
On Fri, Sep 18, 2015 at 02:19:15PM +0900, Joonsoo Kim wrote: > This patchset makes zram to use crypto API in order to support > more compression algorithm. > > The reason we need to support vairous compression algorithms is that > zram's performance is highly depend on workload and compression alg

Re: [PATCH v3 8/9] zram: use crypto API for compression

2015-09-20 Thread Sergey Senozhatsky
On (09/18/15 14:19), Joonsoo Kim wrote: [..] > -static struct zcomp_backend *find_backend(const char *compress) > +static const char *find_backend(const char *compress) > { > int i = 0; > while (backends[i]) { > - if (sysfs_streq(compress, backends[i]->name)) > +

Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API

2015-09-20 Thread Sergey Senozhatsky
On (09/18/15 14:19), Joonsoo Kim wrote: > -/* Never return NULL, may sleep */ > +/* May return NULL, may sleep */ > struct zcomp_strm *zcomp_decompress_begin(struct zcomp *comp) > { > + if (comp->tfm_noctx) > + return NULL; > + > return zcomp_strm_find(comp); > } > > @@ -

Re: [PATCH v3 1/9] crypto: introduce decompression API that can be called via sharable tfm object

2015-09-20 Thread Sergey Senozhatsky
On (09/18/15 14:19), Joonsoo Kim wrote: [..] > @@ -61,7 +61,8 @@ static struct crypto_alg alg = { > .cra_module = THIS_MODULE, > .cra_u = { .compress = { > .coa_compress = crypto842_compress, > - .coa_decompress = crypto842_decomp

Re: [PATCH v3 1/9] crypto: introduce decompression API that can be called via sharable tfm object

2015-09-20 Thread Sergey Senozhatsky
On (09/18/15 14:19), Joonsoo Kim wrote: [..] > static int __init lzo_mod_init(void) > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index e71cb70..31152b1 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -355,6 +355,8 @@ struct compress_alg { >