Re: GPF in ChaCha20 SSSE3 Implementation

2016-01-21 Thread Jason A. Donenfeld
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg17498.html Eli's patch fixes the issue! I'd recommend you send this off for stable inclusion, as it's potentially remotely exploitable. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message

[PATCH] crypto: chacha20_4block_xor_ssse3: Align stack pointer to 64 bytes

2016-01-21 Thread Eli Cooper
This aligns the stack pointer in chacha20_4block_xor_ssse3 to 64 bytes. Fixes general protection faults and potential kernel panics. Cc: sta...@vger.kernel.org Signed-off-by: Eli Cooper --- arch/x86/crypto/chacha20-ssse3-x86_64.S | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

GPF in ChaCha20 SSSE3 Implementation

2016-01-21 Thread Jason A. Donenfeld
Hi Martin, I'm trying to use your ChaPoly implementation and I'm running into quite a bit of trouble. Firstly, it appears that the routine intermittently overwrites boundaries that it shouldn't, resulting in panics, which I'm still looking into, and could be caused by error on my part. But, more i

[PATCH] crypto: skcipher - Add default key size helper

2016-01-21 Thread Herbert Xu
While converting ecryptfs over to skcipher I found that it needs to pick a default key size if one isn't given. Rather than having it poke into the guts of the algorithm to get max_keysize, let's provide a helper that is meant to give a sane default (just in case we ever get an algorithm that has